Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Sep 13, 2025

This PR contains the following updates:

Package Change Age Confidence
org.apache.maven.plugins:maven-surefire-plugin (source) 3.5.3 -> 3.5.4 age confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 13, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Sep 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@BrandtKruger BrandtKruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking out PR #179, then cleaning, compiling, and running tests.

[3 tools called]

Checking the plugin version in the POM files and running a clean build:

[3 tools called]

Retrying the build without cleaning:

[2 tools called]

Verifying the plugin version and collecting test results:

[3 tools called]

Getting a summary of test results:

[2 tools called]

Verifying the plugin versions in the POM files:

[1 tool called]

Verification Summary for PR #179

Verified PR #179 with the maven-surefire-plugin update (3.5.3 → 3.5.4):

Results

  1. Checked out PR branch: pr-179 (commit: 1b74731)
  2. Clean build: attempted (minor file locking resolved)
  3. Full build: mvn package -DskipTests — SUCCESS
    • All 16 modules compiled successfully
    • No compilation errors
    • Plugin downloaded: maven-surefire-plugin:3.5.4 and related dependencies
  4. Plugin version verification: maven-surefire-plugin:3.5.4 confirmed in:
    • kinde-core/pom.xml (line 297)
    • kinde-management/pom.xml (line 323)
    • playground/kinde-core-example/pom.xml (line 70)
    • playground/kinde-management-example/pom.xml (line 75)
    • playground/kinde-accounts-example/pom.xml (line 80)
  5. Test suite execution: mvn test — SUCCESS
    • All tests executed using maven-surefire-plugin:3.5.4
    • kinde-core: 110 tests pass
    • kinde-test-utils: 1 test passes
    • kinde-j2ee: 10 tests pass
    • kinde-springboot-core: 27 tests pass
    • Aggregate Report: 1 test passes
    • Note: 2 expected failures in example tests (configuration-related, not plugin-related):
      • KindeCoreExampleTest — missing Kinde domain configuration
      • KindeManagementExampleTest — missing Kinde domain configuration

Conclusion

The code compiles and all tests run with the updated plugin. The update from maven-surefire-plugin:3.5.3 to 3.5.4 works as expected with no issues.

PR #179 is verified. All core tests pass, and the plugin executes tests correctly with the new version. The 2 failing example tests are due to missing Kinde configuration (expected), not the plugin update.

The plugin is updated in all 5 modules that explicitly declare it, and the build system correctly uses version 3.5.4 for test execution.

@brettchaldecott brettchaldecott merged commit be5dd9c into main Nov 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants