Skip to content

Updated Readme and Manifest with GR 3.10 compatability#63

Open
dkozel wants to merge 1 commit intokit-cel:masterfrom
dkozel:update-manifest
Open

Updated Readme and Manifest with GR 3.10 compatability#63
dkozel wants to merge 1 commit intokit-cel:masterfrom
dkozel:update-manifest

Conversation

@dkozel
Copy link
Collaborator

@dkozel dkozel commented Apr 10, 2024

I haven't checked or updated the other dependencies, but at least this should help clarify things on CGRAN and people reading the repo. Can this also be branched as maint-3.10 please?

Copy link

@noc0lour noc0lour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the version compatibility, if it's not compatible with old GNU Radio we should remove them from the list.

repo: https://github.com/kit-cel/gr-radar
website: https://grradar.wordpress.com
gr_supported_version: v3.7, v3.8
gr_supported_version: v3.7, v3.8, v3.10

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all versions supported at the same time? I'd think that 3.7 & 3.8 won't work after the update to 3.10?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well... Only 3.10 will work on this branch, but the repo has branches for maint-3.7 and maint-3.8. Currently CGRAN only displays the info from the default branch. Including all the available supported versions in the manifest is the current "standard practice". Improving/changing this is a CGRAN level discussion. The Readme, more relevant to people viewing the repo and source code only mentions 3.10 support.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants