Skip to content

Changes to be committed:#64

Open
hellocaoziyi wants to merge 4 commits intokit-cel:masterfrom
hellocaoziyi:master
Open

Changes to be committed:#64
hellocaoziyi wants to merge 4 commits intokit-cel:masterfrom
hellocaoziyi:master

Conversation

@hellocaoziyi
Copy link

modified the file structure and cmake files to migrate to version 3.10.
modified: CMakeLists.txt
modified: README.md
modified: cmake/Modules/gnuradio-radarConfig.cmake
modified: lib/CMakeLists.txt
modified: lib/scatter_plot.h
modified: python/radar/CMakeLists.txt
modified: python/radar/init.py
modified: python/radar/bindings/CMakeLists.txt
new file: python/radar/bindings/bind_oot_file.py
modified: python/radar/bindings/python_bindings.cc

	modified:   CMakeLists.txt
	modified:   README.md
	modified:   cmake/Modules/gnuradio-radarConfig.cmake
	modified:   lib/CMakeLists.txt
	modified:   lib/scatter_plot.h
	modified:   python/radar/CMakeLists.txt
	modified:   python/radar/__init__.py
	modified:   python/radar/bindings/CMakeLists.txt
	new file:   python/radar/bindings/bind_oot_file.py
	modified:   python/radar/bindings/python_bindings.cc
@hellocaoziyi
Copy link
Author

@noc0lour @ryanvolz Can you help me merge? Or are there any changes that need to be made?

@ryanvolz
Copy link
Contributor

I don't have merge powers here, so someone who does will have to come along. I don't think I see anything in here that I would object to, but it might help to break this up into a few smaller PRs for review purposes.

One necessary change would be to remove the __pycache__ directories and corresponding .pyc files from the commit.

It's also unclear to me from the GitHub changed files summary whether the header files are being moved (as desired) or a duplicate set is being added, but I suspect the latter.

@hellocaoziyi
Copy link
Author

Thank you, @ryanvolz. I've mode the modifications as Ryan's suggestions. Following the example of GNU Radio gr-modtool. I've moved the header files form the original location at include/radar to include/gnuradio/radar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants