Skip to content

Refactor code #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkarbowiak merged 2 commits into from
Oct 3, 2025
Merged

Refactor code #161

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8728bc4
Refactor: extract common code to separate function
kkarbowiak Oct 3, 2025
1b612a9
Refactor: reuse existing implementation
kkarbowiak Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions include/argparse.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -964,6 +964,16 @@ namespace argparse

virtual auto get_name_for_error() const -> std::string = 0;

static auto is_negative_number(std::string const & token) -> bool
{
auto num = double();
if (from_string(token, num))
{
return true;
}
return false;
}

private:
ArgumentCommonImpl m_impl;
};
Expand Down Expand Up @@ -1034,10 +1044,7 @@ namespace argparse
{
return true;
}
auto iss = std::istringstream(token.m_token);
auto num = double();
iss >> num;
if (!iss.fail() && (iss.eof() || iss.peek() == std::istringstream::traits_type::eof()))
if (is_negative_number(token.m_token))
{
return true;
}
Expand Down Expand Up @@ -1412,10 +1419,7 @@ namespace argparse
{
return true;
}
auto iss = std::istringstream(token.m_token);
auto num = double();
iss >> num;
if (!iss.fail() && (iss.eof() || iss.peek() == std::istringstream::traits_type::eof()))
if (is_negative_number(token.m_token))
{
return true;
}
Expand Down