Skip to content

Fix MSVC ASan heap-buffer-overflow #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkarbowiak merged 3 commits into from
Mar 6, 2025
Merged

Fix MSVC ASan heap-buffer-overflow #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86ee3c4
Add unit test
kkarbowiak Mar 6, 2025
f82928b
Fix UB in filter view
kkarbowiak Mar 6, 2025
56e7cdd
Extend unit test
kkarbowiak Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/argparse.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,7 @@ namespace argparse
})
| std::views::filter([&past_pseudo_arg](auto const & token)
{
if (past_pseudo_arg)
if (past_pseudo_arg && (token.m_token != "--"))
{
return true;
}
Expand Down
12 changes: 12 additions & 0 deletions test/unittest/test_parsing.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
#include <type_traits>


using namespace std::string_literals;

TEST_CASE("Parsing arguments with help requested disregards parsing errors for missing positional argument")
{
auto parser = argparse::ArgumentParser().add_help(false).handle(argparse::Handle::none);
Expand Down Expand Up @@ -163,3 +165,13 @@ TEST_CASE("Parsing")
CHECK(args.get_value("opt1") == "o1");
CHECK(!args.get("opt2"));
}

TEST_CASE("Parsing")
{
auto parser = argparse::ArgumentParser().handle(argparse::Handle::none);
parser.add_argument("pos").nargs(argparse::zero_or_more);

auto args = parser.parse_args(5, cstr_arr{"prog", "p1", "p2", "--", "p3"});

CHECK(args.get_value<std::vector<std::string>>("pos") == std::vector{"p1"s, "p2"s, "p3"s});
}