Enhancements for image scanning by DreierF · Pull Request #29 · klep/scanline

DreierF · 2019-12-30T20:11:48Z

Hi Scott,

Thanks for your work on this tool.
I found it very useful and a good starting point for my own needs. I'm currently digitalizing a bunch of old printed photos. To make this easier I added some enhancements to scanline that might also be useful for others.

Enhancements are:

An option to specify a specific area that should be scanned for flatbed scanners
An option to specify a creation date that should be stored in the EXIF metadata
An option to auto-trim whitespace surrounding the image
An option to automatically strip additional pixels from the trimmed image (which allows to cut off borders)

Additionally I have done some refactorings/cleanup:

Update to Swift 5
Each class has it's own file
Removed some duplicated code

Let me know what you think 🙂

P.S. I would suggest to look at the changes commit by commit.

klep · 2019-12-31T22:01:54Z

Thanks for the PR @DreierF! This actually includes a suggestion I just made on #30 to make the config object a little smarter! I'll have some time to take a closer look in the coming days.

klep

Great enhancements! Some minor comments and questions, but looks great!

scanline.xcodeproj/project.pbxproj

klep · 2020-01-02T19:14:42Z

scanline/IntExtensions.swift

+//  scanline
+//
+//  Created by Florian Dreier on 12/30/19.
+//  Copyright © 2019 Scott J. Kleper. All rights reserved.


I should probably go and remove this everywhere, maybe just pointing to the LICENSE file. Feel free to omit this line. My name doesn't need to be on everything!

This was just the default header that XCode generated. I replaced the headers now with

// // This code is part of scanline and published under MIT license. //

WDYT?

scanline/ScanlineOutputProcessor.swift

scanline/ScannerController.swift

scanline/ScanConfigurationExtension.swift

klep · 2020-01-02T19:37:56Z

scanline/ArrayExtensions.swift

+
+extension Array where Iterator.Element == Int {
+
+    func doesValueAroundIndexPassFivePercent(index: Int, total: Int) -> Bool {


A comment for this function would be helpful. I'm not 100% sure I get what it's doing

I didn't like this method either. Took this as a chance to refactor the code so that the method is no longer needed. Hope this makes things clearer.

scanline/NSImageExtensions.swift

klep · 2020-01-02T19:42:12Z

scanline/image/CGRectExtensions.swift

@@ -0,0 +1,18 @@
+//
+//  UIImageExtensions.swift


Wrong filename :)

Good catch!

klep · 2020-01-02T19:43:30Z

scanline/Insets.swift

+import Foundation
+
+/// Describes insets that can be applied to a rectangle.
+struct Insets {


Should this just be UIEdgeInsets?

AFAICS UIEdgeInsets is only part of UIKit, which is not linked against scanline as it is a command line application.

Oh, right...

scanline/image/CGRectExtensions.swift

DreierF · 2020-01-04T20:16:52Z

Thanks for your review!

Now opens all scanned images in a single window

klep · 2020-01-04T21:09:23Z

scanline/ScanConfiguration.m

                     @"synonyms": @[@"size"],
                     @"type": @"string",
-                     @"description": @"Specify the size of the area that should be scanned in cm (Default is the whole flatbed scan area)"
+                     @"description": @"Specify the size of the area that should be scanned in cm. Forat is <width>x<height>, e.g. 20x20 (Default is the whole flatbed scan area)"


klep · 2020-01-04T21:10:07Z

scanline/ScannerController.swift

+        guard error == nil else {
+            logger.log("Error received while attempting to open a session with the scanner.")
+            delegate?.scannerControllerDidFail(self)
+            if(configuration.batchScan) {


Suggested change

if(configuration.batchScan) {

if configuration.batchScan {

klep · 2020-01-04T21:10:27Z

scanline/ScannerController.swift

+
+        logger.log("Error received while attempting to close a session with the scanner.")
+        delegate?.scannerControllerDidFail(self)
+        if(configuration.batchScan) {


Suggested change

if(configuration.batchScan) {

if configuration.batchScan {

klep · 2020-01-07T20:33:34Z

scanline Tests/ScanConfigurationTests.m

 #import <XCTest/XCTest.h>

-#import "ScanConfiguration.h"
+#import "../scanline/ScanConfiguration.h"


I was able to get it to work by doing the following:

Change to #import "ScanConfiguration.h" in ScanConfigurationTests.m

Remove everything except ScanConfigurationTests.m and ScanConfiguration.m from the Compile Sources step

Remove #import "scanline-Swift.h" from ScanConfiguration.m

It's not ideal -- we shouldn't need any of the app source files in the test target -- but I'm not sure what the issue is right now with that.

klep · 2020-01-07T20:33:48Z

scanline/Insets.swift

+import Foundation
+
+/// Describes insets that can be applied to a rectangle.
+struct Insets {


Oh, right...

klep · 2020-01-07T20:34:40Z

scanline/Insets.swift

+
+    init(fromString insets: String) {
+        let insetValues = insets.split(separator: ":")
+        self.init(left: Double(insetValues[0])!, top: Double(insetValues[1])!, right: Double(insetValues[2])!, bottom: Double(insetValues[1])!)


Is it possible to avoid the force unwraps here?

klep · 2020-01-07T20:35:58Z

scanline/main.swift


 CFRunLoopRun()
-
-print("Done")


Fair enough...

rramphal · 2022-04-15T19:13:03Z

Hey @klep, I noticed that this PR was last updated in 2020, but there was a recent v2.0 release this year. I'm not sure how many enhancements were made between v1.0 and v2.0, but I was wondering where that leaves this PR and its enhancements. Thank you!

klep · 2022-04-26T19:33:50Z

@rramphal It looks like there were some comments that were not addressed. These do look like worthy changes, but they'd have to be adapted for the newer version...

DreierF added 11 commits December 30, 2019 16:29

Update to Swift 5

123db70

Refactoring: Moved classes to individual files

d45480b

Refactoring: Extracted ScannerConfigurationExtension

1fe5007

Refactoring: Extracted findOutputFilePath

bf3a412

Make logging more minimal

6818ba2

Added area option

23bdff1

Added creation-date option

983f0e7

Added auto-trim option

b421cbf

Added insets option

d1aa2e2

Added quality option

0a6a2dc

Moved file

f8d2115

klep requested changes Jan 2, 2020

View reviewed changes

DreierF added 5 commits January 4, 2020 19:39

Simplified trimming code and fixed trimming on high resolution scanners

4ffd5b1

Moved extensions to group

dfcffa3

"Fixed" copyright headers

db19019

Refactored image cropping code

72f22f6

Rework

c7fef38

DreierF requested a review from klep January 4, 2020 20:11

Fix

0158181

Improved combination of batch + open

9510a16

Now opens all scanned images in a single window

klep requested changes Jan 7, 2020

View reviewed changes


		extension Array where Iterator.Element == Int {

		func doesValueAroundIndexPassFivePercent(index: Int, total: Int) -> Bool {


		CFRunLoopRun()

		print("Done")

Conversation

DreierF commented Dec 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

klep commented Dec 31, 2019

Uh oh!

klep left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DreierF commented Jan 4, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rramphal commented Apr 15, 2022

Uh oh!

klep commented Apr 26, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

DreierF commented Dec 30, 2019 •

edited

Loading