This repository was archived by the owner on Dec 18, 2019. It is now read-only.
Fix uncaught error when 'Reprompt Master Password' option is enabled#9
Open
bnt0 wants to merge 2 commits intoklingenm:masterfrom
Open
Fix uncaught error when 'Reprompt Master Password' option is enabled#9bnt0 wants to merge 2 commits intoklingenm:masterfrom
bnt0 wants to merge 2 commits intoklingenm:masterfrom
Conversation
…er password is enabled for password
export2.js
Outdated
| } else { | ||
| var link = document.createElement("a"); | ||
| if (link.download !== undefined) { // feature detection | ||
| if (link.download !== "undefined") { // feature detection |
Owner
There was a problem hiding this comment.
Did you test this? This is comparison straight to a property, not to the result of "typeof", sure this is supposed to be a string?
Author
|
My bad, it only concerned line 17. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Reprompt Master Password' option is enabled for a password the script fails on line 19. (Chromium 50.0.2661.102, Linux).
typeofalways returns a string.typeof(username_fill) == undefinedreturns false, so the script didn't wait for the item to be loaded. Fixed by comparing with string value.