Skip to content

Conversation

@cardil
Copy link
Contributor

@cardil cardil commented Mar 14, 2025

Changes

  • 🗑️ Deprecate knative.dev/hack/schema

/kind deprecation

Related knative/toolbox#38
Related knative-extensions/sample-controller#931

Release Note

The knative.dev/hack/schema package is now deprecated. Please use K8s' controller-gen instead.

@knative-prow knative-prow bot added the kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. label Mar 14, 2025
@knative-prow knative-prow bot requested review from evankanderson and mgencur March 14, 2025 16:53
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 14, 2025
@cardil
Copy link
Contributor Author

cardil commented Mar 14, 2025

/assign @dprotaso
/cc @upodroid
/cc @dsimansk

@cardil
Copy link
Contributor Author

cardil commented Mar 14, 2025

@knative-prow knative-prow bot requested review from matzew and pierDipi March 14, 2025 17:01
@knative-prow
Copy link

knative-prow bot commented Mar 14, 2025

@cardil: GitHub didn't allow me to request PR reviews from the following users: codegangsta, dan-j.

Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

Some leftover usages:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot requested a review from astelmashenko March 14, 2025 17:01
@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2025
@knative-prow
Copy link

knative-prow bot commented Mar 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants