magetasks: Set GOTOOLCHAIN=auto when installing Golang dependencies #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the `GOTOOLCHAIN` environment variable to "auto" when running `go install` for dependencies. This leverages the Go 1.21+ feature to automatically download and use the Go toolchain version specified in the dependency's `go.mod` file. This improves build reproducibility and simplifies environment setup by removing the need to have a specific Go version pre-installed.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
approved
cardil
changed the title
Contributor
Author
|
/assign @maschmid |
Contributor
Author
|
/cc @maschmid |
|
/lgtm |
Contributor
Author
|
/cherrypick support/golang-1.22 |
Contributor
|
@cardil: new pull request created: #41 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Related: knative/hack#436
What this PR does, why we need it:
Set the
GOTOOLCHAINenvironment variable to "auto" when runninggo installfor dependencies.This leverages the Go 1.21+ feature to automatically download and use the Go toolchain version specified in the dependency's
go.modfile. This improves build reproducibility and simplifies environment setup by removing the need to have a specific Go version pre-installed.This PR should prevent failures like this.
/kind bug