Exclude passwords from all notifications with exclude_password opt#84
Open
stephenbradshaw wants to merge 3 commits intoknavesec:masterfrom
Open
Exclude passwords from all notifications with exclude_password opt#84stephenbradshaw wants to merge 3 commits intoknavesec:masterfrom
stephenbradshaw wants to merge 3 commits intoknavesec:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
exclude_passwordoption for excluding passwords from notifications still shows passwords at Spray start and Spray continuation allowing correct credentials to be inferred from message content from reading multiple messages - this PR fixes issue by also hiding passwords in these messages ifexclude_passwordoption set.