-
Notifications
You must be signed in to change notification settings - Fork 38
AP-24593, AP-25234: update scripting editor #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the @knime/scripting-editor dependency from version 0.0.118 to 0.0.119 and adapts the codebase to accommodate API changes in the new version. The changes primarily involve updates to method signatures and the introduction of new service methods.
Key changes:
- Updated scripting editor dependency to version 0.0.119
- Adapted to new API signatures for settings service methods that now use object parameters
- Added support for new RPC methods and initial data retrieval methods in service interfaces
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated @knime/scripting-editor dependency to version 0.0.119 |
| test-setup/setup.ts | Added mock implementations for new service methods (callRpcMethod, getSettingsInitialData) |
| python-scripting-service.ts | Added optional chaining for safer settings access |
| main.ts | Changed App import to dynamic import and removed unused static import |
| EnvironmentSettings.vue | Updated register call to use object parameter with initialValue property |
| mock-data.ts | Updated mock factory to wrap settings in object parameter |
| browser-mock-services.ts | Updated settings service mock creation to use object parameter |
984c794 to
10a73f8
Compare
AP-25234 (Allow usage of JSONForms dialogs generated from NodeParameters in Scripting Editors)
10a73f8 to
434bd61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- org.knime.python3.scripting.nodes/js-src/package-lock.json: Language not supported
|



AP-24593 (Show K-AI disclaimer in Scripting Editor only once)
AP-25234 (Allow usage of JSONForms dialogs generated from NodeParameters in Scripting Editors)