Skip to content

Conversation

@HedgehogCode
Copy link
Contributor

@HedgehogCode HedgehogCode commented Dec 19, 2025

AP-24593 (Show K-AI disclaimer in Scripting Editor only once)
AP-25234 (Allow usage of JSONForms dialogs generated from NodeParameters in Scripting Editors)

Copilot AI review requested due to automatic review settings December 19, 2025 09:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the @knime/scripting-editor dependency from version 0.0.118 to 0.0.119 and adapts the codebase to accommodate API changes in the new version. The changes primarily involve updates to method signatures and the introduction of new service methods.

Key changes:

  • Updated scripting editor dependency to version 0.0.119
  • Adapted to new API signatures for settings service methods that now use object parameters
  • Added support for new RPC methods and initial data retrieval methods in service interfaces

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
package.json Updated @knime/scripting-editor dependency to version 0.0.119
test-setup/setup.ts Added mock implementations for new service methods (callRpcMethod, getSettingsInitialData)
python-scripting-service.ts Added optional chaining for safer settings access
main.ts Changed App import to dynamic import and removed unused static import
EnvironmentSettings.vue Updated register call to use object parameter with initialValue property
mock-data.ts Updated mock factory to wrap settings in object parameter
browser-mock-services.ts Updated settings service mock creation to use object parameter

@HedgehogCode HedgehogCode force-pushed the enh/AP-24593-update-scripting-editor branch from 984c794 to 10a73f8 Compare December 19, 2025 12:54
AP-24593 (Show K-AI disclaimer in Scripting Editor only once)
AP-25234 (Allow usage of JSONForms dialogs generated from NodeParameters in Scripting Editors)
AP-25234 (Allow usage of JSONForms dialogs generated from NodeParameters in Scripting Editors)
@HedgehogCode HedgehogCode force-pushed the enh/AP-24593-update-scripting-editor branch from 10a73f8 to 434bd61 Compare December 19, 2025 13:01
Copilot AI review requested due to automatic review settings December 19, 2025 13:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • org.knime.python3.scripting.nodes/js-src/package-lock.json: Language not supported

@HedgehogCode HedgehogCode marked this pull request as ready for review December 19, 2025 13:24
@HedgehogCode HedgehogCode requested a review from a team as a code owner December 19, 2025 13:24
@sonarqubecloud
Copy link

@chaubold chaubold merged commit d63ae4b into master Dec 19, 2025
3 of 4 checks passed
@chaubold chaubold deleted the enh/AP-24593-update-scripting-editor branch December 19, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants