Skip to content

changes#1

Open
knorrest wants to merge 4 commits intomasterfrom
some-branch
Open

changes#1
knorrest wants to merge 4 commits intomasterfrom
some-branch

Conversation

@knorrest
Copy link
Owner

@knorrest knorrest commented Jan 7, 2020

---Please read and delete this text before creating this pull request---
Thanks a lot for the pull request you are going to do!
Please verify that you validate these points:

  • indentation is made with 4 spaces
  • your pull request contains only changes intended (no refactoring, line return added, ... that could make code review harder. Make another one if you think it is needed...)
  • run and verify that existing tests pass. Add some new units tests, if needed.
  • update the documentation, if needed.
  • update the release notes file

Kalle Norrestam added 2 commits May 3, 2019 14:11
Kalle Norrestam added 2 commits January 7, 2020 09:16
@knorrest
Copy link
Owner Author

knorrest commented Jan 7, 2020

CodeScene Delta Analysis Results
Risk 7
Quality Gates Fail
Description The change is high risk as it is more wide-spread than your typical change sets, adding 170 lines, deleting 0 lines of code. The risk increases as the author has somewhat lower experience in this repository.
Warnings Delta Analysis Info
  • 2 files in this change set did not exist with the same name on the main branch. This is probably because those files have been renamemd. Skipping code health checks for those files.

Degrades in Code Health
  • CommitParserTests.cs degrades from a Code Health of 10 -> 9.67
Code Health Delta Descriptions: CommitParserTests.cs
  • Degradations:
    • Excess Number of Function Arguments (f has 8 arguments, threshold = 5 arguments) - new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant