Add date and datetime conversions #56
Conversation
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
I'll fix the reeks. |
|
We'll need this in query, too: https://github.com/knowndecimal/fulfil/blob/main/lib/fulfil/query.rb#L49-L118 |
|
Actually, let's talk through this. We're already doing some of this in another spot. |
lib/fulfil/domain_parser.rb
Outdated
| end | ||
|
|
||
| def disable_escape_html_entities | ||
| return unless defined?(ActiveSupport) && ActiveSupport.respond_to?(:escape_html_entities_in_json=) |
There was a problem hiding this comment.
Fulfil::DomainParser#disable_escape_html_entities manually dispatches method call
There was a problem hiding this comment.
@cdmwebs rake test was erroring out when my guard clause was only return unless defined?(ActiveSupport) not sure exactly what to do to fix this codeclimate reek.
lib/fulfil/domain_parser.rb
Outdated
| end | ||
|
|
||
| def enable_escape_html_entities | ||
| return unless defined?(ActiveSupport) && ActiveSupport.respond_to?(:escape_html_entities_in_json=) |
There was a problem hiding this comment.
Fulfil::DomainParser#enable_escape_html_entities manually dispatches method call
|
|
||
| private | ||
|
|
||
| def date_as_object(date) |
There was a problem hiding this comment.
Fulfil::DomainParser#date_as_object doesn't depend on instance state (maybe move it to another class?)
| Converter.date_as_object(date) | ||
| end | ||
|
|
||
| def datetime_as_object(datetime) |
There was a problem hiding this comment.
Fulfil::DomainParser#datetime_as_object doesn't depend on instance state (maybe move it to another class?)
lib/fulfil/domain_parser.rb
Outdated
| Converter.datetime_as_object(datetime) | ||
| end | ||
|
|
||
| def disable_escape_html_entities |
There was a problem hiding this comment.
Fulfil::DomainParser#disable_escape_html_entities doesn't depend on instance state (maybe move it to another class?)
lib/fulfil/domain_parser.rb
Outdated
| ActiveSupport.escape_html_entities_in_json = false | ||
| end | ||
|
|
||
| def enable_escape_html_entities |
There was a problem hiding this comment.
Fulfil::DomainParser#enable_escape_html_entities doesn't depend on instance state (maybe move it to another class?)
lib/fulfil/query.rb
Outdated
| end | ||
|
|
||
| def handle_hash(field, key, value, options) | ||
| if %i[gte gt lte lt].any? { |op| value.key?(op) } |
There was a problem hiding this comment.
Fulfil::Query#handle_hash refers to 'value' more than self (maybe move it to another class?)
| end | ||
| end | ||
|
|
||
| def handle_hash(field, key, value, options) |
There was a problem hiding this comment.
Fulfil::Query#handle_hash has 4 parameters
| end | ||
| end | ||
|
|
||
| def handle_hash(field, key, value, options) |
There was a problem hiding this comment.
Fulfil::Query#handle_hash has approx 7 statements
|
Figuring out how to fix these codeclimate reeks. I've got dates in the queries. Do those look right @cdmwebs? |
|
|
||
| module Fulfil | ||
| module Concerns | ||
| module HtmlEntityHandler |
There was a problem hiding this comment.
Fulfil::Concerns::HtmlEntityHandler has no descriptive comment
| end | ||
|
|
||
| def disable_escape_html_entities | ||
| return unless defined?(ActiveSupport) && ActiveSupport.respond_to?(:escape_html_entities_in_json=) |
There was a problem hiding this comment.
Fulfil::Concerns::HtmlEntityHandler#disable_escape_html_entities manually dispatches method call
| end | ||
|
|
||
| def enable_escape_html_entities | ||
| return unless defined?(ActiveSupport) && ActiveSupport.respond_to?(:escape_html_entities_in_json=) |
There was a problem hiding this comment.
Fulfil::Concerns::HtmlEntityHandler#enable_escape_html_entities manually dispatches method call
| enable_escape_html_entities | ||
| end | ||
|
|
||
| def disable_escape_html_entities |
There was a problem hiding this comment.
Fulfil::Concerns::HtmlEntityHandler#disable_escape_html_entities doesn't depend on instance state (maybe move it to another class?)
| ActiveSupport.escape_html_entities_in_json = false | ||
| end | ||
|
|
||
| def enable_escape_html_entities |
There was a problem hiding this comment.
Fulfil::Concerns::HtmlEntityHandler#enable_escape_html_entities doesn't depend on instance state (maybe move it to another class?)
| end | ||
| end | ||
|
|
||
| def handle_operator_comparison(key, value) |
There was a problem hiding this comment.
Fulfil::Query#handle_operator_comparison doesn't depend on instance state (maybe move it to another class?)
|
Code Climate has analyzed commit 857569a and detected 9 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 96.6% (50% is the threshold). This pull request will bring the total coverage in the repository to 88.9% (1.2% change). View more on Code Climate. |
Fulfil requires dates and datetimes to be formatted in an object that contains a iso8601 datetime. This PR adds a conversion class and integrates it into the model to update the domains automatically.