Skip to content

feat: use cookie.httpOnly in reset#143

Open
Jiasm wants to merge 1 commit intokoajs:masterfrom
Jiasm:patch-1
Open

feat: use cookie.httpOnly in reset#143
Jiasm wants to merge 1 commit intokoajs:masterfrom
Jiasm:patch-1

Conversation

@Jiasm
Copy link

@Jiasm Jiasm commented Jan 21, 2025

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

When a user sets httpOnly: false, the default behavior of reset might result in document.cookie not being updated on Safari browsers. This can lead to a mismatch between the cookie information in the application and the cookies obtained by the frontend. To ensure consistency in cookie data, I recommend referencing the behavior of cookie.httpOnly during the reset process.

Alternatively, should we consider using all configuration options available with cookies here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant