fix: stronger cache hash (FNV-1a 64-bit) and GeoIP abort on timeout#210
Open
Rau1CS wants to merge 1 commit intokoala73:mainfrom
Open
fix: stronger cache hash (FNV-1a 64-bit) and GeoIP abort on timeout#210Rau1CS wants to merge 1 commit intokoala73:mainfrom
Rau1CS wants to merge 1 commit intokoala73:mainfrom
Conversation
…rs on timeout hashString() used a 32-bit DJB2 hash prone to collisions at scale; replaced with FNV-1a 64-bit (BigInt) for ~2^32 birthday-bound collision resistance while staying synchronous and edge-runtime compatible. GeoIP worker pool in cyber-threats used Promise.race without cancelling in-flight fetches on timeout. Now threads AbortController signal through workers → geolocateIp → fetchGeoIp → fetchJsonWithTimeout so all pending requests are aborted when the overall timeout fires. Closes koala73#180, closes koala73#196 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@Rau1CS is attempting to deploy a commit to the Elie Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hashString()in_upstash-cache.jswith FNV-1a 64-bit using BigInt. The birthday-bound collision threshold goes from ~65K to ~4B entries — a 65,000x improvement while remaining synchronous and edge-runtime compatible. All 5 caller files are unchanged.cyber-threats.jsusedPromise.raceto enforce an overall timeout, but the losing workers (and their in-flightfetchcalls) kept running. Now anAbortControllersignal is threaded throughhydrateThreatCoordinates → geolocateIp → fetchGeoIp → fetchJsonWithTimeout, so all pending requests are cancelled the moment the overall timeout fires.Changes
api/_upstash-cache.jshashString(): DJB2 32-bit → FNV-1a 64-bit (BigInt)api/cyber-threats.jshydrateThreatCoordinates: createAbortController, passsignalthrough worker chain;fetchJsonWithTimeout: forward external abort signal;fetchGeoIp/geolocateIp: accept + passsignalparameterChecklist
npx tsc --noEmitpassesnode:crypto, uses BigInt + standardAbortController)hashStringsignature unchanged; newsignalparams are optional)Closes #180, closes #196
🤖 Generated with Claude Code