-
Notifications
You must be signed in to change notification settings - Fork 3
4.16 session explorer update #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
erincbailey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed in Github - so a little harder to know all the context and didn't review image placement. have a few comments. Probably good to make edits - one more review - and publish so it's improved. Then I can review live site for further changes.
docs/modules/automation-testing/pages/scripting/auto-generate-an-appium-script.adoc
Outdated
Show resolved
Hide resolved
docs/modules/devices/partials/network-payload-capture/launch-session-explorer.adoc
Outdated
Show resolved
Hide resolved
docs/modules/scriptless-automation/pages/run-scriptless-with-the-kobiton-portal.adoc
Outdated
Show resolved
Hide resolved
docs/modules/session-explorer/pages/analytics/review-network-payload-data.adoc
Show resolved
Hide resolved
|
Edits here: a6bdd30 with some comments |
|
preview link: http://10.2.7.208/session-explorer/ |
|
added changes for https://kobiton.atlassian.net/browse/KOB-47667 in this branch as well. |
madison-oates
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor feedback
docs/modules/automation-testing/pages/scripting/add-action-groups-in-appium-script.adoc
Outdated
Show resolved
Hide resolved
docs/modules/automation-testing/pages/scripting/add-action-groups-in-appium-script.adoc
Outdated
Show resolved
Hide resolved
docs/modules/automation-testing/pages/scripting/add-action-groups-in-appium-script.adoc
Outdated
Show resolved
Hide resolved
docs/modules/automation-testing/pages/scripting/add-action-groups-in-appium-script.adoc
Outdated
Show resolved
Hide resolved
tungmhoang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adapted feedbacks and added the test result analysis guide.
WalkthroughThis update introduces new and revised documentation across multiple modules, focusing on enhanced instructions, updated UI references, and expanded feature explanations for Kobiton's testing and session analysis tools. Additions include detailed guides for grouping actions in Appium scripts, reviewing test result analysis, and searching sessions by tag. Numerous navigation, image, and terminology updates provide improved clarity and consistency. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant SessionExplorer
participant Documentation
User->>Documentation: Reads guide on grouping actions in Appium script
User->>SessionExplorer: Runs Appium test with step groups
SessionExplorer-->>User: Displays grouped actions in timeline
User->>Documentation: Reads how to review test result analysis
User->>SessionExplorer: Opens session analysis
SessionExplorer-->>User: Shows validation issues and analysis table
User->>Documentation: Reads about searching sessions by tag
User->>SessionExplorer: Searches sessions using session_tag: query
SessionExplorer-->>User: Returns filtered session list
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 11
🔭 Outside diff range comments (1)
docs/modules/session-explorer/pages/search-for-a-session.adoc (1)
87-92:⚠️ Potential issueGrammar: plural verb agreement
Change “The search suggestions displays” to “The search suggestions display” to correct subject–verb agreement.
🧹 Nitpick comments (28)
docs/modules/session-explorer/pages/analytics/reinspect-appium-elements.adoc (1)
55-55:Details
❓ Verification inconclusive
Standardize UI label casing
The UI action "Download inventory" should exactly match the product's label. Confirm that it appears with lowercase "inventory" in the application and update all occurrences accordingly.
Use:
🏁 Script executed:
rg -n 'Download inventory' -A1 docs/modules/session-explorerLength of output: 522
Please verify and standardize the “Download inventory” label
Confirm that the UI action label in the application matches exactly (lowercase “inventory” vs. uppercase “Inventory”) and then update every occurrence in the docs to match.Occurrences to check/update:
- docs/modules/session-explorer/pages/analytics/reinspect-appium-elements.adoc:55
- docs/modules/session-explorer/pages/analytics/reinspect-appium-elements.adoc:57 (image alt text)
docs/modules/automation-testing/pages/capabilities/add-flexcorrect.adoc (1)
55-55: Verify xref anchor and refine link syntax
Please confirm that the anchor#_test_result_analysis_overviewexists in review-test-result-analysis.adoc. Also consider adding a space after the comma in the attribute section for readability, e.g.:
xref:session-explorer:analytics/review-test-result-analysis.adoc#_test_result_analysis_overview[how many elements were corrected, window=read-later].docs/modules/scriptless-automation/pages/scriptless-requirements.adoc (1)
126-126: Use AsciiDoc link macro for consistency
Replace the raw URL with thelink:macro for consistent formatting, e.g.:
link:https://developer.chrome.com/docs/devtools/remote-debugging/webviews/#configure_webviews_for_debugging[this link]docs/modules/session-explorer/pages/validations/validate-accessibility.adoc (1)
10-12: Unify terminology and verify image attributes
The text refers to a “green marker” while the alt text calls it a “green dot.” For consistency, choose one term across copy and alt text. Also, confirm that reducing the image width from 500 to 250 px maintains legibility for all users.docs/modules/session-explorer/pages/custom-search-queries.adoc (2)
119-129: Align parameter description style
Rather than “You can search for sessions using a specific tag,” consider matching the phrasing of other parameters, e.g.:- You can search for sessions using a specific tag. + Returns all sessions matching the specified session tag.
132-133: Correct cross-reference link text
The link display text “Session tags” doesn’t match the target section “Session status or type.” Please update to:- see xref:session-explorer:search-for-a-session.adoc#_use_session_status_or_type[Session tags]. + see xref:session-explorer:search-for-a-session.adoc#_use_session_status_or_type[Session status or type].docs/modules/session-explorer/pages/analytics/review-crash-logs.adoc (1)
21-23: Pluralize in alt text for consistency
The alt text reads “Download the crash log” but the heading and note refer to crash logs. Update to:-image:session-explorer:copy-crash-log-context.png[width=1000,alt="Download the crash log"] +image:session-explorer:copy-crash-log-context.png[width=1000,alt="Download the crash logs"]docs/modules/session-explorer/pages/analytics/review-network-payload-data.adoc (1)
8-9: Improve clarity of prerequisite wording
The current sentence may read as if only the automation session needs NPC enabled. Consider a rewrite:- You'll need to complete a xref:manual-testing:local-devices/capture-network-payload-data.adoc[manual session,window=read-later] _or_ an xref:automation-testing:local-devices/capture-network-payload-data.adoc[automation session,window=read-later] with network payload capture enabled. + You'll need to complete either a manual or an automation session with network payload capture enabled. See xref:manual-testing:local-devices/capture-network-payload-data.adoc[manual session,window=read-later] or xref:automation-testing:local-devices/capture-network-payload-data.adoc[automation session,window=read-later].docs/modules/session-explorer/pages/analytics/review-device-logs.adoc (2)
20-20: Refine alt text for filter close-up image
Use “of” instead of “to” and ensure plural consistency (Logs). For example:
alt="A closeup of the filter in the Review Device Logs feature"
24-24: Correct alt text to reflect the search bar
The current alt mentions “filter” but this image shows the search bar. Update to:
alt="A closeup of the search bar in the Review Device Logs feature"docs/modules/session-explorer/pages/validations/index.adoc (1)
4-7: Refine possessive phrasing for clarity
Consider rewording “your app or website’s UI design and user accessibility” to “the UI design and accessibility of your app or website” to avoid awkward plural possessives.docs/modules/session-explorer/partials/launch-session-explorer.adoc (1)
11-11: Simplify phrasing for UI appearance
For brevity, change “Once you select your session, the Session Explorer page will appear.” to “Once you select your session, Session Explorer appears.”docs/modules/session-explorer/pages/analytics/review-system-metrics.adoc (1)
25-43: Refine alt text grammar across metric close-ups
Use “A closeup of the [Metric] section of System Metrics” rather than “to” or mixing metric names. E.g.:
alt="A closeup of the Memory section of System Metrics"docs/modules/session-explorer/pages/index.adoc (2)
4-7: Enhance introduction clarity
The first paragraph covers multiple capabilities—consider merging the troubleshooting and validation points into a more concise sentence to improve flow and reduce repetition.
9-9: Vary phrasing to avoid repetition
The phrase “helps you” appears again here; consider rephrasing to maintain reader engagement and avoid redundancy.docs/modules/session-explorer/pages/analytics/review-test-result-analysis.adoc (4)
1-2: Page title vs. navtitle
Both the title and:navtitle:are identical. Consider shortening the navtitle (e.g., “Test Result Analysis”) if a more concise navigation label is preferred.
4-5: Introduction wording
Consider rephrasing “after your test session” to “after a test session” to maintain consistent article usage.
12-15: Section heading style
“Test result analysis overview” reads well, but verify whether title case is preferred (e.g., “Test Result Analysis Overview”) based on other AsciiDoc headings.
16-23: Bullet list formatting
The nested bullets under Validation Type are logical. You can remove the backslashes escaping the parentheses (\(C)) since AsciiDoc supports literal parentheses.docs/modules/session-explorer/pages/analytics/use-the-session-timeline.adoc (1)
74-78: Format code marker
Wrap the step-group marker in monospace (e.g.,`kobiton:stepGroup`) instead of single quotes for consistency with other code elements.docs/modules/devices/partials/network-payload-capture/launch-session-explorer.adoc (1)
9-9: Session Explorer appearance phrasing
Consider rewording to “The Session Explorer page appears” or “Session Explorer opens” for greater precision.docs/modules/automation-testing/pages/scripting/add-action-groups-in-appium-script.adoc (4)
4-5: Consider tightening the introduction.
The opening is informative but could be more concise. For example:
“Group related Appium actions to mark test phases and simplify troubleshooting.”
16-19: Consistently format commands and capabilities.
Use backticks around both the command name and capability key for clarity.
E.g.,Use the `updateSettings` Appium command to set `kobiton:stepGroup` to your group name.
20-22: Disambiguate example captions.
Both snippets currently use “Example (JavaScript)”. Consider labeling one “Quick snippet” and the other “Full script example” so readers know what they’re looking at.
140-145: Clarify limitation phrasing.
Consider tightening to:* After adding an action group, setting the group name to an empty string assigns subsequent commands to the previous group.docs/modules/session-explorer/pages/manage-sessions.adoc (3)
22-24: Clarify “change this” reference.
Replace vague “change this” with a precise action:- You can also change this during a test session. + You can also update session info during a test session.
37-39: Minor grammar and punctuation in logs section.
- Change to “Last-mile speed test logs are only available…”
- Add a period after the sentence beginning “To download the last mile speed test logs…”
67-90: Review nested list formatting.
The ordered list and nested bullet items may not render as intended. In AsciiDoc, consider:. You’ll see the last five sessions with the same tag, including: + * Session statuses (e.g., passed, failed) * Device and OS information * Details like Session ID and creation date
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (83)
docs/modules/devices/images/select-analyse-response-times-context.pngis excluded by!**/*.pngdocs/modules/devices/images/select-analyze-response-time-context.pngis excluded by!**/*.pngdocs/modules/devices/images/select-sessions-closeup.pngis excluded by!**/*.pngdocs/modules/integrations/images/jira-create-ticket-button.pngis excluded by!**/*.pngdocs/modules/integrations/images/jira-create-ticket-context.pngis excluded by!**/*.pngdocs/modules/integrations/images/jira-create-ticket-integration.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/appium-inspector-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/appium-inspector-select-element.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/attributes-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/battery-closeup.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/capture-payload-indicator.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/color-contrast-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/content-labeling-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/copy-crash-log-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/copy-link-closeup.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/cpu-closeup.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/date-range-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/device-info-closeup.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/download-inventory-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/download-screenshot-closeup.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/edit-session-description-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/edit-session-name-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/expand-dropdown-to-see-details.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/hover-attribute-closeup.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/inspect-elements-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/issue description-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/issue-arrows.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/issue-marker-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/jump-to-step-npc-closeup.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/launch-device-logs.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/launch-session-explorer-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/logs-closeup.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/logs-last-mile-speed.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/memory-closeup.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/move-screen-closeup.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/move-through-issues-closeup.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/network-closeup.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/observe-request.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/play_pause-closeup.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/previous-next-closeup.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/previous-next.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/recording-closeup.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/red-dot-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/refresh-inventory-closeup.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/review-device-log-copied-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/review-device-logs-filter-closeup.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/review-device-logs-search-closeup.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/review-system-metrics-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/search-bar-closeup.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/search-session-id-closeup.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/see-package-name-size-npc-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/select-a-session-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/select-analyze-response-time-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/select-explorer-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/select-red-dots-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/select-session-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/select-session-id-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/select-sessions-closeup.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/select-sessions-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/session-explorer-accessibility-validation.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/session-explorer-automated-test-case-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/session-explorer-timeline-group-actions.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/session-info-closeup.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/session-overview-context copy.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/session-overview-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/session-overview-execution-history.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/session-overview-test-result-analysis.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/session-overview.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/session-search-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/session-tags-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/system-metrics-temperature.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/test-steps-closeup.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/timeline-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/touch-target-size-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/view-crash-logs-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/view-details-accessbility-validation-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/view-test-step-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/webview-closeup.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/yellow-dot-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/yellow-dots-on-timeline-context.pngis excluded by!**/*.pngdocs/modules/session-explorer/images/zoom.pngis excluded by!**/*.pngdocs/modules/session-explorer/partials/select-sessions-context.pngis excluded by!**/*.pngdocs/modules/test-management/images/convert-test-case.pngis excluded by!**/*.png
📒 Files selected for processing (31)
docs/modules/automation-testing/nav.adoc(1 hunks)docs/modules/automation-testing/pages/capabilities/add-flexcorrect.adoc(1 hunks)docs/modules/automation-testing/pages/get-a-session-id/using-the-kobiton-portal.adoc(1 hunks)docs/modules/automation-testing/pages/scripting/add-action-groups-in-appium-script.adoc(1 hunks)docs/modules/automation-testing/pages/scripting/auto-generate-an-appium-script.adoc(2 hunks)docs/modules/devices/partials/network-payload-capture/launch-session-explorer.adoc(1 hunks)docs/modules/integrations/pages/jira/create-a-jira-ticket.adoc(2 hunks)docs/modules/scriptless-automation/pages/run-scriptless-with-the-kobiton-portal.adoc(1 hunks)docs/modules/scriptless-automation/pages/scriptless-requirements.adoc(3 hunks)docs/modules/session-explorer/nav.adoc(1 hunks)docs/modules/session-explorer/pages/analytics/index.adoc(1 hunks)docs/modules/session-explorer/pages/analytics/reinspect-appium-elements.adoc(1 hunks)docs/modules/session-explorer/pages/analytics/review-crash-logs.adoc(1 hunks)docs/modules/session-explorer/pages/analytics/review-device-logs.adoc(1 hunks)docs/modules/session-explorer/pages/analytics/review-network-payload-data.adoc(3 hunks)docs/modules/session-explorer/pages/analytics/review-system-metrics.adoc(3 hunks)docs/modules/session-explorer/pages/analytics/review-test-result-analysis.adoc(1 hunks)docs/modules/session-explorer/pages/analytics/use-the-session-timeline.adoc(3 hunks)docs/modules/session-explorer/pages/custom-search-queries.adoc(1 hunks)docs/modules/session-explorer/pages/index.adoc(1 hunks)docs/modules/session-explorer/pages/manage-sessions.adoc(3 hunks)docs/modules/session-explorer/pages/search-for-a-session.adoc(2 hunks)docs/modules/session-explorer/pages/validations/index.adoc(1 hunks)docs/modules/session-explorer/pages/validations/validate-accessibility.adoc(1 hunks)docs/modules/session-explorer/partials/launch-session-explorer.adoc(1 hunks)docs/modules/test-management/pages/create-a-test-case.adoc(1 hunks)docs/modules/test-management/pages/manage-test-steps.adoc(1 hunks)docs/modules/test-management/pages/remediation/annotate-a-test-step.adoc(1 hunks)docs/modules/test-management/pages/validation/text-validation.adoc(1 hunks)ui-bundle-docs/partials/head-info.hbs(1 hunks)ui-bundle-widget/partials/head-info.hbs(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: publish-docs-test
- GitHub Check: Test Build
🔇 Additional comments (56)
docs/modules/test-management/pages/validation/text-validation.adoc (1)
6-6: Approve image width reductionThe width adjustment from 1000 to 500 aligns with other documentation for improved consistency and readability.
docs/modules/session-explorer/nav.adoc (1)
7-7: Approve new analytics navigation entryThe new
review-test-result-analysis.adoclink is correctly indented and enhances discoverability of the test result analysis feature.docs/modules/test-management/pages/manage-test-steps.adoc (1)
16-18:Details
✅ Verification successful
Confirm terminology and image consistency
Updated "Select Convert to Test Case" and the
convert-test-case.pngreference. Validate that the UI uses this exact label and that the new image file is correctly named and present.Use:
🏁 Script executed:
rg -n 'convert-test-case.png' -A1 docs/modules/test-management/pages/manage-test-steps.adocLength of output: 172
🏁 Script executed:
#!/bin/bash # Verify that the new image file exists find . -type f -name 'convert-test-case.png' # Search the codebase for the exact UI label to confirm consistency rg -n 'Convert to Test Case'Length of output: 2828
Terminology and Image Consistency Verified
I’ve confirmed that the UI label Convert to Test Case is used verbatim across all relevant documentation and that the image file exists at
docs/modules/test-management/images/convert-test-case.pngand is correctly referenced inmanage-test-steps.adoc. No further changes are needed.docs/modules/test-management/pages/create-a-test-case.adoc (2)
19-19: LGTM! Terminology improvement enhances clarity.The change from "Automated Test Case" to "Convert to Test Case" better describes the actual action being performed and aligns with the UI updates mentioned in the PR objectives.
21-21:Details
✅ Verification successful
Verify the image file exists in the documentation assets.
The image reference and alt text updates are consistent with the terminology change. Please ensure the
convert-test-case.pngfile exists in the appropriate images directory.
🏁 Script executed:
#!/bin/bash # Description: Verify the convert-test-case.png image file exists in the documentation # Expected: Find the image file in the appropriate assets/images directory fd -t f "convert-test-case.png"Length of output: 89
✅ Image File Verified
The image
convert-test-case.pngwas found atdocs/modules/test-management/images/convert-test-case.png. No further action is needed—this update is ready to merge.docs/modules/test-management/pages/remediation/annotate-a-test-step.adoc (2)
16-16: LGTM! Consistent terminology update across documentation.The terminology change matches the update in
create-a-test-case.adoc, maintaining consistency across the documentation set.
18-18: LGTM! Consistent image reference update.The image reference and alt text are updated consistently with the terminology change and match the update in
create-a-test-case.adoc.ui-bundle-widget/partials/head-info.hbs (1)
13-13: Verify SEO impact of changing from dynamic to static meta descriptions.The change from dynamic page-specific descriptions to a static description represents a significant shift in SEO strategy. While the static description is well-written, this could impact search engine optimization for individual pages.
Consider the following implications:
- Pros: Consistent branding message, simpler maintenance
- Cons: Less specific page targeting, potential reduction in search relevance
Please ensure this change aligns with your SEO strategy and consider A/B testing the impact on search rankings.
ui-bundle-docs/partials/head-info.hbs (1)
13-13: Consistent with widget bundle template.The meta description change matches the update in
ui-bundle-widget/partials/head-info.hbs, maintaining consistency across both template bundles. Please refer to the SEO impact considerations mentioned for the widget bundle template.docs/modules/automation-testing/nav.adoc (1)
16-16: New scripting guide link added
The navigation entry correctly integrates the new “add-action-groups-in-appium-script.adoc” under Scripting. Ensure this path matches the actual file location.docs/modules/scriptless-automation/pages/scriptless-requirements.adoc (2)
10-10: Introduction sentence is clear and accurate
The updated guidance clearly sets expectations before the supported‐actions table.
78-78: Corrected action name
“Pinch to zoom” correctly replaces the previous text and aligns with other action labels.docs/modules/integrations/pages/jira/create-a-jira-ticket.adoc (2)
18-18: Updated UI reference to Session Explorer
The instruction now correctly points users to Session Explorer instead of Session Overview.
28-28: Emphasized field name for clarity
Using Description emphasizes the field and matches styling elsewhere.docs/modules/automation-testing/pages/scripting/auto-generate-an-appium-script.adoc (3)
13-13: Reflects new “Convert to Test Case” flow
The step is updated to use Session Explorer and the renamed action, aligning with UI changes.
15-15: Confirm image reference correctness
Please verify that thetest-management:convert-test-case.pngasset is accessible from this page and that it reflects the Convert to Test Case UI.
47-47: Added C# - NUnit option
Including C# – NUnit completes the list of supported frameworks.docs/modules/scriptless-automation/pages/run-scriptless-with-the-kobiton-portal.adoc (1)
22-24: 👍 Addressed previous feedback on Test Case button
The updated instruction covers both Convert to Test Case and View Test Case states, and the image alt now matches the button.docs/modules/session-explorer/pages/analytics/review-crash-logs.adoc (1)
15-17: Steps look good
The new numbered instructions clearly guide the user through selecting Crash validation, the red marker, and View Details.docs/modules/session-explorer/pages/analytics/review-network-payload-data.adoc (1)
28-29: Verify reduced image width legibility
The payload indicator image was resized from 1000 px to 500 px. Ensure key details remain clear at the narrower width.docs/modules/session-explorer/pages/analytics/review-device-logs.adoc (2)
10-13: Consistent selection wording and visuals
The change from “Review Device Logs” to “Device Logs” and updated image width align well with the new UI.
18-21: Expanded log filter options are clear
Including Debug and Verbal alongside the existing levels improves coverage.docs/modules/session-explorer/partials/launch-session-explorer.adoc (1)
5-5: Verify image legibility at reduced size
The screenshot width is set to 150 px, which may make UI details hard to see. Please confirm clarity or consider a slightly larger width.docs/modules/session-explorer/pages/analytics/index.adoc (2)
4-7: Strong introduction copy
The expanded intro succinctly highlights Session Explorer’s analytics capabilities and aligns with the new content.
12-18: Verify naming of Appium elements link
The xref usesreinspect-appium-elements.adoc—please confirm the file exists and whether “reinspect” should instead be “inspect” for consistency across the analytics pages.docs/modules/session-explorer/pages/analytics/review-system-metrics.adoc (2)
4-4: Include temperature in system metrics
Great addition of device temperature to the overview—this completes the metric set.
15-15: UI label updated correctly
Switching the menu option from “Review System Metrics” to “System Metrics” matches the updated interface.docs/modules/session-explorer/pages/index.adoc (1)
11-11: Alt text and image width consistency
The alt text “The Session Explorer page” aligns with other overview pages, and the full-width image is appropriate for the landing page.docs/modules/session-explorer/pages/search-for-a-session.adoc (2)
26-26: Approve reduced image width
Reducing the date-range image to 750px improves readability on narrower layouts without losing detail.
34-37: Approve renaming to session status/type
The new section header and description clearly distinguish status/type filtering from tag-based searches.docs/modules/session-explorer/pages/analytics/review-test-result-analysis.adoc (5)
6-9: Include path consistency
Theinclude::session-explorer:partial$launch-session-explorer.adoc[]matches other pages’ patterns and correctly reuses the shared partial.
10-11: Default view description
Highlighting Test Result Analysis as the default view is clear and helpful for first-time users.
24-31: Overview metrics bullets
The items for AI Progress, Screens, Issues, and View all are concise and consistent with other session-explorer docs.
32-34: Anchor ID usage
The[##_start_analysis]anchor precedes “Start analysis.” Verify that link fragments elsewhere reference#_start_analysis(single underscore) to ensure correct navigation.
35-36: Start analysis paragraph
The step to select Start Analysis is clear.docs/modules/session-explorer/pages/analytics/use-the-session-timeline.adoc (6)
16-16: Zoom image width
Reducing the zoom control screenshot to 250px focuses on the UI element and avoids unnecessary whitespace.
34-34: Updated icon label
Changing the copy-link instruction to Copy link to test step matches the UI label precisely.
44-45: View validation issues section
The anchor and heading additions for “View validation issues” align with the expanded validation icon support.
47-52: Validation icons list
The four icon types (A, C, R, S) and their descriptions are comprehensive and well-formatted.
54-54: Validation icons screenshot
The narrower 250px image highlights the relevant timeline icons effectively.
64-67: Learn more links
The “Learn more about” links correctly reference the validations and analytics pages; they follow existing cross-ref conventions.docs/modules/devices/partials/network-payload-capture/launch-session-explorer.adoc (7)
1-1: Context phrasing update
The change to “In Kobiton, select Sessions.” clearly establishes the starting point.
3-3: Tab selection screenshot
The 150px close-up effectively highlights the Sessions tab without extra detail.
5-5: Cross-ref to search guide
Linking to the dedicated “Find a session” page correctly consolidates search instructions.
7-7: Search result screenshot
The full-width image clearly shows the search input for session IDs.
11-11: Explorer tab screenshot
The alt text “Select Explorer tab” clearly conveys the action.
13-13: Dropdown instruction
“From the dropdown, choose Response Time Analysis.” clearly directs users to the correct item.
17-17: Follow-up action link
Linking to the network payload data review page is clear and actionable.docs/modules/automation-testing/pages/scripting/add-action-groups-in-appium-script.adoc (5)
1-3: Title and navtitle are clear and consistent.
The page title and:navtitle:match and accurately describe the content.
6-14: Action group setting table looks correct.
The capability name, description, and default value are clearly documented.
27-29: Examples section header is clear.
The transition into the example code is well signposted.
35-83: Full script example is comprehensive.
The JavaScript sample covers setup, grouping, and teardown. No issues spotted in the logic or flow.
136-139: Link to Session Explorer timeline is correct.
The xref to the action‐groups timeline page appears valid.docs/modules/session-explorer/pages/manage-sessions.adoc (3)
10-11: Reduced image width improves layout.
Theselect-sessions-closeup.pngat 150px will render more cleanly in the flow.
16-17: Strengthened Session Overview phrasing.
Switching to second-person and removing “window” aligns with style–nice improvement.
65-66: TIP block closing syntax is correct.
The admonition opens and closes properly with====.
docs/modules/automation-testing/pages/get-a-session-id/using-the-kobiton-portal.adoc
Show resolved
Hide resolved
docs/modules/session-explorer/pages/analytics/review-network-payload-data.adoc
Outdated
Show resolved
Hide resolved
docs/modules/session-explorer/pages/analytics/review-network-payload-data.adoc
Outdated
Show resolved
Hide resolved
docs/modules/session-explorer/pages/analytics/review-system-metrics.adoc
Outdated
Show resolved
Hide resolved
docs/modules/session-explorer/pages/analytics/review-test-result-analysis.adoc
Outdated
Show resolved
Hide resolved
docs/modules/devices/partials/network-payload-capture/launch-session-explorer.adoc
Outdated
Show resolved
Hide resolved
docs/modules/automation-testing/pages/scripting/add-action-groups-in-appium-script.adoc
Show resolved
Hide resolved
docs/modules/automation-testing/pages/scripting/add-action-groups-in-appium-script.adoc
Show resolved
Hide resolved
docs/modules/automation-testing/pages/scripting/add-action-groups-in-appium-script.adoc
Show resolved
Hide resolved
removed scriptless automation reference as not relevant here any more.
Summary
Related PRs, issues, or features (optional)
Metadata
PR contributor checklist
My PR follows the Kobiton Docs contributor guidelines, meaning:
nav.adocfile.en-us) from my URLs.Summary by CodeRabbit
New Features
Improvements
Bug Fixes
Style