Fix graceful shutdown #209
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
docker compose downtakes 10 seconds and Docker forcefully kills the container because graceful shutdown doesn't work.Root cause: The bash script in
koel-entrypointbecomes PID 1, and doesn't forward signals (like SIGWINCH/SIGTERM) to the Apache child process. Docker waits for timeout, then sends SIGKILL.Solution
Use
execto replace bash with Apache as PID 1, so signals reach Apache directly.Also quotes
"$@"for proper argument handling (best practice).Result
Container now shuts down gracefully in 1-2 seconds instead of being killed after 10 seconds.