Better error messages for nested structs#224
Open
virtuald wants to merge 3 commits intokonradhalas:masterfrom
Open
Better error messages for nested structs#224virtuald wants to merge 3 commits intokonradhalas:masterfrom
virtuald wants to merge 3 commits intokonradhalas:masterfrom
Conversation
- dicts now have the key name in them - lists/tuples now have the index in them
- Previously just raised original exception, now includes the field name
|
Been working in something similar, IMO this changes makes only sense if they are applied to all other types of exceptions (MissingValue, UnionMatch) but this can be done gradually if maintainers agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old error message:
New error message: