-
Notifications
You must be signed in to change notification settings - Fork 43
✨ Add llama_stack to release workflows #508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughAdds Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
eee02df to
0c6c79f
Compare
Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
0c6c79f to
96f65ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
.github/actions/make-bundle/action.yml(2 hunks).github/workflows/create-release.yml(1 hunks)bundle/manifests/konveyor-operator.clusterserviceversion.yaml(2 hunks)helm/templates/deployment.yaml(1 hunks)helm/values.yaml(1 hunks)roles/tackle/defaults/main.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: run-ci / e2e-api-integration-tests
🔇 Additional comments (7)
helm/templates/deployment.yaml (1)
66-67: LGTM! Environment variable correctly references Helm values.The
RELATED_IMAGE_LLAMA_STACKenvironment variable is properly configured using the Helm template syntax and follows the same pattern as other related image environment variables..github/workflows/create-release.yml (1)
231-231: LGTM! Release workflow correctly includes llama_stack with mirrored image.The
llama_stackparameter uses thequay.io/konveyorregistry, which is correct for the release process. The image mirroring step (lines 187-210) will copy external images likedocker.io/llamastack/distribution-startertoquay.io/konveyor/distribution-starterduring the release.bundle/manifests/konveyor-operator.clusterserviceversion.yaml (2)
362-363: LGTM! Environment variable properly added to ClusterServiceVersion.The
RELATED_IMAGE_LLAMA_STACKenvironment variable follows the established pattern for other related images in the operator deployment specification.
567-568: LGTM! Related image entry correctly configured.The
llama-stackentry in the relatedImages list uses the same image reference as the environment variable, maintaining consistency. The hyphenated name format matches the convention used for other related images..github/actions/make-bundle/action.yml (2)
64-67: LGTM! Input parameter properly defined.The
llama_stackinput follows the established convention for other image inputs in this action, with appropriate description, optional requirement, and empty default value.
107-107: LGTM! Conditional logic correctly propagates llama_stack to bundle options.The conditional check and OPTS append follow the same pattern as other image parameters, ensuring the
llama_stackvalue is properly passed to the Helm-based bundle generation process.roles/tackle/defaults/main.yml (1)
332-332: LGTM! Environment-driven image configuration correctly implemented.The change to
kai_llm_proxy_image_fqinproperly reads from theRELATED_IMAGE_LLAMA_STACKenvironment variable with an appropriate fallback to the default image. This aligns with the pattern used for other image configurations in this file (e.g.,hub_image_fqinon line 28) and integrates well with the environment variables added in the deployment manifests.
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.