Open
Conversation
Resolves issue kortina#139 by fixing ESLint indentation errors and resolves the broken build on master by updating dependencies and fixing type issues. ### Fixes - Fixed indentation in NoteParser.ts line 164 (ESLint error from kortina#139) - Fixed BacklinksTreeDataProvider.ts EventEmitter type to allow undefined for fire() call - Updated @types/node from v11 to v18 to fix Buffer type compatibility issues - Updated @types/glob from v7 to v8 and glob from v7 to v9 to fix minimatch compatibility
Author
|
happy to work on other issues that have been posted but need this one in master so its stable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
NoteParser.tsline 164 (ESLint error)BacklinksTreeDataProvider.tsEventEmitter type to allowundefinedforfire()call@types/nodefrom v11 to v18 (Buffer type compatibility)@types/globfrom v7 to v8 andglobfrom v7 to v9 (minimatch compatibility)Test plan
npm run lintpassesnpm run compilepassesnpm run testpasses (25 tests)