updated files to pass curly and bitwise tests in jshint#64
Open
iticus wants to merge 1 commit intokothic:masterfrom
Open
updated files to pass curly and bitwise tests in jshint#64iticus wants to merge 1 commit intokothic:masterfrom
iticus wants to merge 1 commit intokothic:masterfrom
Conversation
Contributor
|
Would it be easier to disable the rules in JSHint? |
Author
|
It would probably be easier to just disable the rules (options), however using the curly brackets makes the code less error-prone. Being more explicit about using the bitwise operators helps too in my opinion. |
Collaborator
|
Whatever we do, we should be consistent. Currently the setup says that lint thing should be fine, but it is not. So either we drop it now or we fix the code now, either is fine with me (I'm not a JS guy anyway). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to build the project using the instructions provided (by using grunt more specifically) but I got errors such as
[L152:C17] W116: Expected '{' and instead saw 'continue'I fixed the code to conform with JSHint's curly option (by adding curly braces even when the block consists of only one statement) and bitwise option (by adding
/*jslint bitwise: true */).Using these modifications I'm able to build the project successfully.