adapt to changes in AndroidAsync performed to fix issue 461#516
Open
mkoslacz wants to merge 1 commit intokoush:masterfrom
Open
adapt to changes in AndroidAsync performed to fix issue 461#516mkoslacz wants to merge 1 commit intokoush:masterfrom
mkoslacz wants to merge 1 commit intokoush:masterfrom
Conversation
I performed changes to adapt this library to work on top of AndroidAsync modified by me in commit koush/AndroidAsync@98a9d50. It's rather quick fix, using not the best patterns, to get the stuff done, but it works flawlessly. Probably you will want to adjust it to meet your standards. I used FileCache named storeCache in Ion to resolve method calls that were static, and I changed Ion reference to static in IonBitmapRequestBuilder, assuming that Ion is anywany called in static way, to prevent changing other methods to non-static.
Owner
|
Ion is not always called in a static way. There may be different ion instances with different configurations, middleware, etc. |
Owner
|
I think you want to use getResposneCacheMiddleware().getCache() instead of the store cache. The store cache is an experimental/undocumented thing to do disk i/o |
Author
|
I'll take a look later. If it's not always called in a static way, static methods in IonBitmapRequestBuilder will probably need to be changed to non-static, which can cause need for further changes. Although, in my simple use case it works good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I performed changes to adapt this library to work on top of AndroidAsync modified by me in commit koush/AndroidAsync@98a9d50.
It's rather quick fix, using not the best patterns, to get the stuff done, but it works flawlessly. Probably you will want to adjust it to meet your standards.
I used FileCache named storeCache in Ion to resolve method calls that were static, and I changed Ion reference to static in IonBitmapRequestBuilder, assuming that Ion is anywany called in static way, to prevent changing other methods to non-static.