Skip to content

Conversation

@Amnesia1000
Copy link
Contributor

Fixed small bug in README

Fixed small bug in README
@kript
Copy link
Owner

kript commented Apr 16, 2023

Depends on what OS you are doing this on - when I run it on bash in linux I need the quotes to manage the space, otherwise the shell doesn't pickup the file correctly.

@Amnesia1000
Copy link
Contributor Author

Yes, I forgot to clarify. This file must be modified manually. But for reasons of order, it is better to remove the space in the file name, than to modify the readme to use the real name. It could be clarified better. But it seems to me that it is better to maintain a uniform format (since the name of the PDF does not maintain the standards that have been maintained in the nomenclature of the files, a pnparcade bug)

Added the explanatory text and step-by-step to make the command sequence work perfectly. Since my English is not perfect, I would need you to check and tell me if it is understood.
Added the explanatory text and step-by-step to make the command sequence work perfectly. Since my English is not perfect, I would need you to check and tell me if it is understood.
@Amnesia1000
Copy link
Contributor Author

Added the explanatory text and step-by-step to make the command sequence work perfectly. Since my English is not perfect, I would need you to check and tell me if it is understood.

@kript
Copy link
Owner

kript commented Apr 23, 2023

Added the explanatory text and step-by-step to make the command sequence work perfectly. Since my English is not perfect, I would need you to check and tell me if it is understood.

Thanks for this and apologies for the delay in replying. Your English is great, no worries there! I am still not keen on the idea of renaming the file - if you extract the zip file each week, or come to it new, then this is an extra step which is avoided by quoting. If anything there is an safe coding argument for quoting all the file names (I got into this habit due to shellcheck feedback if you've not seen that tool!).

If someone were to automate more of the steps (#16 ), then your suggestion could be done there (although I am tempted to write some code to generate the list of files from the zip which would solve the issue as well!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants