Fixed issue with device port updates not being caught#1
Open
meatheadmike wants to merge 22 commits intokris2k2:masterfrom
Open
Fixed issue with device port updates not being caught#1meatheadmike wants to merge 22 commits intokris2k2:masterfrom
meatheadmike wants to merge 22 commits intokris2k2:masterfrom
Conversation
bug fix for device detection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If left long enough, wemo dimmers will eventually switch the port they are listening on. If we don't catch this, they simply stop responding on SmarthThings. This can be tested by resetting the dimmer (hold down the tiny button at the bottom of the switch until it glows white). One it restarts it will pick a port - usually a new one.
This PR addresses that issue. There are a few other code updates based on best practices that I gleaned from the API docs. The fix is primarily just one line in the subscribeToDevices() function:
discoverAllWemoTypes()