Fuzz.Extra.sequence now respects the order of its input fuzzers#8
Open
jbrains wants to merge 1 commit intoktonon:masterfrom
Open
Fuzz.Extra.sequence now respects the order of its input fuzzers#8jbrains wants to merge 1 commit intoktonon:masterfrom
jbrains wants to merge 1 commit intoktonon:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know that this is a breaking change, but it seemed strange to me that
sequencewould turn the fuzzers[a, b, c]into a fuzzer that produces lists like[c, b, a]. Accordingly, I've added a simple test to illustrate the behavior I was expected and have "fixed" the function.I can understand if you'd rather not introduce a breaking change abruptly like this I'm open to alternatives to suggesting how to introduce this change into the library. At a minimum, if
sequenceis going to retain its current behavior, then I would recommend emphasizing that in its documentation.