chore(optimizer): Add unit tests for Optimizer KubernetesBackend#334
Open
ruskaruma wants to merge 2 commits intokubeflow:mainfrom
Open
chore(optimizer): Add unit tests for Optimizer KubernetesBackend#334ruskaruma wants to merge 2 commits intokubeflow:mainfrom
ruskaruma wants to merge 2 commits intokubeflow:mainfrom
Conversation
…flow#126) Signed-off-by: ruskaruma <ishaan.sinha10@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds comprehensive unit tests for Optimizer’s KubernetesBackend to cover all public methods and expands mocked Kubernetes/Katib interactions to support those scenarios.
Changes:
- Added fixtures + mock handlers to simulate Katib Experiment/Trial CRUD, events, and logs.
- Added new parametrized tests covering
optimize, job lifecycle methods, logs, results, polling, deletion, and events. - Renamed prior
test_optimizetotest_optimize_no_input_mutationto avoid a name collision.
Signed-off-by: ruskaruma <ishaan.sinha10@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds unit tests for the Optimizer KubernetesBackend, covering all 8 public methods:
optimize,list_jobs,get_job,get_job_logs,get_best_results,wait_for_job_status,delete_job, andget_job_events. Addressesreview feedback from #224 which went stale.
Also renames the existing
test_optimize(input mutation test) totest_optimize_no_input_mutationto avoid name collision with the newtest_optimizethat verifies Experiment CR creation.Which issue(s) this PR fixes:
Fixes #126
Checklist: