Skip to content

Bug fix while comparing status and obj name #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArnobKumarSaha merged 2 commits into from
Dec 9, 2025
Merged

Bug fix while comparing status and obj name #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ca20a8
big fix
anisurrahman75 Jun 28, 2025
8ac6b84
handle fewer tasks
anisurrahman75 Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/controller/batch/taskqueue_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,9 @@ func (r *TaskQueueReconciler) syncTaskQueueStatus(ctx context.Context, tq *queue
}
}
}
if r.getInProgressTaskCount(tq) < tq.Spec.MaxConcurrentTasks { // In case of fewer tasks than max concurrent, we should processPendingTasks
shouldRequeue = false
}
return shouldRequeue, utilerrors.NewAggregate(errs)
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/controller/batch/watcher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ func (r *TaskQueueReconciler) handleResourcesUpdate(ctx context.Context, obj int
return nil
}
if _, err := r.syncTaskQueueStatus(ctx, tq, func(key string) bool {
return key == newObj.GetName()
return key == fmt.Sprintf("%s/%s", newObj.GetNamespace(), newObj.GetName())
}); err != nil {
return fmt.Errorf("failed to sync task status: %w", err)
}
Expand Down
Loading