Bump k8s.io base dependency to 1.31 #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Min Jin <minkimzz@amazon.com>
Signed-off-by: Min Jin <minkimzz@amazon.com>
k8s-ci-robot
added
sig/api-machinery
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yue9944882 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Signed-off-by: Min Jin <minkimzz@amazon.com>
yue9944882
force-pushed
the
bump-k8s-1-31
branch
from
e03bdf1 to
9aa7aeb
Compare
Signed-off-by: Min Jin <minkimzz@amazon.com>
Signed-off-by: Min Jin <minkimzz@amazon.com>
yue9944882
force-pushed
the
bump-k8s-1-31
branch
from
c9c2ff5 to
14aa44c
Compare
yue9944882
added
the
lgtm
tamalsaha
reviewed
Apr 22, 2025
Comment on lines
-101
to
-103
| // change: apiserver-runtime | ||
| genericServer = ApplyGenericAPIServerFns(genericServer) | ||
|
|
There was a problem hiding this comment.
This breaks OCM cluster-gateway. Why was this removed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
k8s.io/*dependency to 1.31.1. Meanwhile, it replaced the nested sample-apiserver source code with the latest from 1.31