Problem of the order of TIA1_Hela clip_data PrismNet pu#3
Open
ZizhengYang wants to merge 1 commit intokuixu:masterfrom
Open
Problem of the order of TIA1_Hela clip_data PrismNet pu#3ZizhengYang wants to merge 1 commit intokuixu:masterfrom
ZizhengYang wants to merge 1 commit intokuixu:masterfrom
Conversation
If using ``` exp/EXP_NAME/train.sh pu PrismNet TIA1_Hela clip_data ``` then there will have an error ``` FileNotFoundError: [Errno 2] Unable to open file (unable to open file: name = 'data/PrismNet/pu.h5', errno = 2, error message = 'No such file or directory', flags = 0, o_flags = 0) ``` I couldn't understand why there is this weird url 'data/PrismNet/pu.h5' so I decide to change position of the command. It seems the right order should be: exp/prismnet/train.sh TIA1_Hela clip_data PrismNet pu
Shigo-45
referenced
this pull request
in Shigo-45/PrismNet
Feb 6, 2026
Previously only PlainCNN2D1D accepted mode parameter. PlainCNN2D, BiLSTMBaseline, and BiGRUBaseline would fail when instantiated via --arch flag because main.py passes mode=args.mode to all models. Changes: - Add mode='pu' parameter to PlainCNN2D.__init__() - Add mode='pu' parameter to BiLSTMBaseline.__init__() - Add mode='pu' parameter to BiGRUBaseline.__init__() - Add docstrings explaining mode is accepted for compatibility Tested: - All models instantiate successfully with mode parameter - Backward compatibility maintained (existing code works) - All forward passes succeed with correct output shapes Resolves Medium severity issue #3 from code review. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If using
then there will have an error
I couldn't understand why there is this weird url 'data/PrismNet/pu.h5' so I decide to change position of the command.
It seems the right order should be: exp/prismnet/train.sh TIA1_Hela clip_data PrismNet pu