Draft
Conversation
Owner
|
Hi @lukaslihotzki and thank you for experimenting with this! The graphics library has a fairly large API. Making it polymorphic across backends is taking a tall at the code clarity and quality. I wonder if we can expose it such that the user would enable "gles" as a feature and see this API: blade_graphics::Device; // main device
blade_graphics::fallback::Device; // GLES deviceSo essentially GLES feature would bring another implementation exposed inside "fallback" namespace, and the user can use both. That would allow Zed (and other users) to potentially have different renderers, e.g. |
01be6ef to
3a37283
Compare
Contributor
Author
|
Any interest in picking this back up? This is a blocker for zed on many devices (already mentioned in the issue reports related to this). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft shows an approach how both Vulkan and GLES can be supported by a single executable. In the first commit, all traits specific to the backend are moved from the crate root to the common directory, which is included in both backends as separate modules using
pathattributes. In the following commits, the traits are made more abstract from specific backends:derivefeature.These changes are sufficient to support multiple backends in Zed, for example (zed-industries/zed#14931). However, blade could be made more generic with extra traits (for example, Texture handling).
fixes #130