Merged
Conversation
- Update ESLint config to ignore .vite/deps/ directory - Remove unused imports in MenuModal.vue, ManagePickersView.vue, PendingBinsView.vue - Fix unused variables in DailyCountSetting.vue, PageLayout.vue - Replace all 'any' types with proper TypeScript types - Enable lint workflow in .github/workflows/lint.yml - Fix TypeScript errors in v-model bindings and error refs
Deploying bintraq with
|
| Latest commit: |
ab6b37f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e1c2a065.bintraq.pages.dev |
| Branch Preview URL: | https://70-fix-linting.bintraq.pages.dev |
ReviewSummary of Changes
Overall FeedbackNo new issues spotted – the code is much cleaner now that linting is enforced. Great work on fixing those accumulated errors, @Pertempto! 🚀 |
|
Heads up @Pertempto, as the changes are linting-related and don't introduce user-facing features or fixes, appVersion doesn't need incrementing per the repo guidelines. If this changes, let me know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #70