feat: acl endpoint

[Pertempto]

Resolves #41

Also did a TON of other clean up and fixes

[Pertempto]

/opencode please fix the changelog

[github-actions]

The CHANGELOG references PR #44 but this is PR #45 - please update to reference the correct PR number for accurate tracking.

[github-actions]

The type assertion userId.(string) on line 58 could panic if the context value isn't a string. Consider using the safe assertion from line 23-27 for consistency.

[github-actions]

Add validation to prevent submission of empty ACL rule arrays, similar to the suggestion in previous comments but not yet implemented.

[Pertempto]

/opencode please fix the changelog

[opencode-agent]

Failed to parse the text response

opencode session  |  github run

[github-actions]

Add validation to reject empty ACL rule arrays to prevent unnecessary processing. Add this after binding the JSON but before the validation loop:

if len(aclRules) == 0 {
    c.JSON(http.StatusBadRequest, gin.H{"error": "At least one ACL rule required"})
    return
}

[github-actions]

In src/handlers/acl.go, the validateAclRule function should take the rule by value instead of pointer since it doesn't modify the rule, and clean up the redundant type assertion.

[github-actions]

In doc/src/content/docs/acl.mdx, the example requests still show the old format with .acl.allow action and payload containing user/item/action. They should be updated to show .acl.addRule action with the new payload format including the type field.

[github-actions]

Nit: In validateAclRule, pass the rule by value instead of pointer since it doesn't modify the rule.

[github-actions]

In src/handlers/user.go, lines 58 and 85: The type assertions callerUserId.(string) could panic if the context value isn't a string. Consider using safe assertions like in PostAcl to prevent runtime errors.

if callerUserIdStr, ok := callerUserId.(string); !ok {
    log.Printf("... unexpected user_id type")
    c.JSON(http.StatusInternalServerError, gin.H{"error": "Internal server error"})
    return
}
// use callerUserIdStr

[github-actions]

@Pertempo, in src/handlers/user.go, lines 40, 58, and 85: The type assertions callerUserId.(string) lack safe type assertions, which could panic if the context value isn't a string. Please use safe assertions with error handling.

if callerUserIdStr, ok := callerUserId.(string); !ok {
    log.Printf("unexpected user_id type")
    c.JSON(http.StatusInternalServerError, gin.H{"error": "Internal server error"})
    return
}
// use callerUserIdStr

[github-actions]

In src/handlers/acl.go, the validateAclRule function checks patterns but doesn't explicitly validate that required fields (user, item, action) are non-empty. The error messages are generic and could benefit from specific validation of empty required fields.

func validateAclRule(rule models.AclRule) error {
    if strings.TrimSpace(rule.User) == "" {
        return errors.New("user field is required")
    }
    if strings.TrimSpace(rule.Item) == "" {
        return errors.New("item field is required")
    }
    if strings.TrimSpace(rule.Action) == "" {
        return errors.New("action field is required")
    }
    if rule.Type != "allow" && rule.Type != "deny" {
        return errors.New("type must be either 'allow' or 'deny'")
    }
    // existing pattern validations...
    return nil
}

[github-actions]

@Pertempto, the code review looks good! I've reviewed the ACL endpoint implementation and have some minor feedback. Can you take a look at these points?

[Pertempto]

This is far from perfect but this PR is big enough and accomplishes most of my main objectives. Merging for now and cleaning up minor things later.