Merged
Conversation
- Remove imports of deleted domain separator traits (OpeningProofDomainSeparator, CircuitProofDomainSeparator, etc.) - Replace old spongefish imports (ProofError, codecs) with minimal setup - Use domain_separator!() macro with .instance(&0u8) for basic functionality - Update prove functions to extract proofs from prover_state.narg_string() - Remove manual .unwrap() calls since prove functions now return Vec<u8> directly - Remove unused imports and unnecessary mutable variables - Simplify batch verification to individual verification for benchmarking purposes All benchmark files now compile successfully with the new spongefish API patterns. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
martyall
force-pushed
the
upgrade-spongefish
branch
2 times, most recently
from
6a23457 to
50c7c88
Compare
martyall
force-pushed
the
upgrade-spongefish
branch
from
50c7c88 to
c00261c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.