driver/pe6216: add support for Aten PE6216 PDU

[DanielKriz]

Description
We are using the Aten PE6216 PDU on our testfleet and we want to use labgrid for test management. This PDU is not present in labgrid power drivers or in the pdudaemon project, hence we have to add it.

I did test it on our test fleet with few very simple tests:

import time

def test_power_on(target):
    pwd = target.get_driver('NetworkPowerDriver')
    pwd.on()
    time.sleep(10.0)
    assert pwd.get() == True

def test_power_cycle(target):
    pwd = target.get_driver('NetworkPowerDriver')
    pwd.cycle()
    time.sleep(10.0)
    assert pwd.get() == True

def test_power_off(target):
    pwd = target.get_driver('NetworkPowerDriver')
    pwd.off()
    time.sleep(10.0)
    assert pwd.get() == False

(PDU takes some time to change states as it has built-in delay between changes (althrough they can be turned of with 'no-wait' option in the HTTP request))

Checklist

• Documentation for the feature
• Tests for the feature
• The arguments and description in doc/configuration.rst have been updated
• PR has been tested

[Bastian-Krause]

Thanks for taking the time to contribute to labgrid! PR looks good to me.

(PDU takes some time to change states as it has built-in delay between changes (althrough they can be turned of with 'no-wait' option in the HTTP request))

I can't find the 'no-wait' option in that pdf. Could you explain why you decided against using this option?

[codecov]

Codecov Report

❌ Patch coverage is 40.90909% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.2%. Comparing base (caf7833) to head (a2557a5).
⚠️ Report is 2 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
labgrid/driver/power/pe6216.py	40.9%	13 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           master   #1324     +/-   ##
========================================
- Coverage    45.2%   45.2%   -0.1%     
========================================
  Files         173     174      +1     
  Lines       13721   13743     +22     
========================================
+ Hits         6203    6212      +9     
- Misses       7518    7531     +13     

Flag	Coverage Δ
3.10	45.2% <40.9%> (-0.1%)	⬇️
3.11	45.2% <40.9%> (-0.1%)	⬇️
3.12	45.2% <40.9%> (-0.1%)	⬇️
3.13	45.1% <40.9%> (-0.1%)	⬇️
3.14	45.1% <40.9%> (-0.1%)	⬇️
3.9	45.2% <40.9%> (-0.1%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DanielKriz]

I am sorry for such a late reply. I made a mistake, it is not a no-wait (that is just our internal name), in the documentation it is called on_immediate and off_immediate.

I have decided against this option because it is safeguarding the DUTs against rapid switching of power, that might occur with immediate mode. I think that in more cases a lot of people would then implement such wait manually (with time.sleep or something like that) as the safety is from my point of view more important than speed. (And PE6216 this feature built-in).

Probably the best and most flexible solution would be some kind of option, that could be put inside the labgrid configuration, but I am not sure if there is any support in labgrid for that right now.

[DanielKriz]

Hello, I would like to ask about the state of this pull request? What should I do to make it accepted?

Is the problem the coverage? Could you give me some pointers about how should I approach it? I am not really sure how to test power drivers.

[tadeas-vintrlik]

Greetings,

What is the state of this PR? We could really use it.

[tadeas-vintrlik]

@Bastian-Krause is there something missing for this to get merged? We have been using a fork for almost two years at this point.

[Bastian-Krause]

Force-pushed: rebased, add check for HTTP errors, reformatted, document that default username/password is expected, add import test, use ExecutionError instead of RuntimeError