qemudriver: add support for netdev option in add_port_forward

[aparcar]

Description

In case there are more user network interfaces defined, allow to specific the netdev. If omitted, an empty string is passed and the behaviour is like before.

This is useful for testing OpenWrt inside a QEMU instance, since OpenWrt expects by default a LAN interface on eth0 and a WAN interface (with uplink) on eth1. Previously the port forward would always be added to eth1, which doesn't support SSH due to firewall policies. By adding the netdev to the forward function, the SSHDriver works as expected.

Checklist

• Documentation for the feature
• Tests for the feature

• The arguments and description in doc/configuration.rst have been updated

• Add a section on how to use the feature to doc/usage.rst

• Add a section on how to use the feature to doc/development.rst

• PR has been tested

• Man pages have been regenerated

[aparcar]

I'm not sure if this feature is to OpenWrt specific

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.2%. Comparing base (b327f81) to head (f9697e6).
⚠️ Report is 2 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@          Coverage Diff           @@
##           master   #1391   +/-   ##
======================================
  Coverage    45.2%   45.2%           
======================================
  Files         174     174           
  Lines       13743   13747    +4     
======================================
+ Hits         6212    6221    +9     
+ Misses       7531    7526    -5     

Flag	Coverage Δ
3.10	45.2% <100.0%> (+<0.1%)	⬆️
3.11	45.2% <100.0%> (+<0.1%)	⬆️
3.12	45.2% <100.0%> (+<0.1%)	⬆️
3.13	45.2% <100.0%> (+<0.1%)	⬆️
3.14	45.2% <100.0%> (+<0.1%)	⬆️
3.9	45.2% <100.0%> (+<0.1%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jluebbe]

Looks good otherwise. Please fix the typo, rebase and mark it as "ready for review".

[sjg20]

with typo fixed

[aparcar]

@jluebbe this should be ready now, please have another look, thanks

[Bastian-Krause]

What about hostfwd_remove? Doesn't that need the netdev parameter, too?

[aparcar]

Thanks @Bastian-Krause I incorporated your suggestions

[Bastian-Krause]

Force-pushed: rebased, prevent double space in QMP command, adjust commit subject to fit labgrid's style

[aparcar]

🍿