fix: handling of empty password in SSHDriver and NetworkService#1814
Open
flxzt wants to merge 1 commit intolabgrid-project:masterfrom
Open
fix: handling of empty password in SSHDriver and NetworkService#1814flxzt wants to merge 1 commit intolabgrid-project:masterfrom
flxzt wants to merge 1 commit intolabgrid-project:masterfrom
Conversation
Signed-off-by: Felix Zwettler <Felix.Zwettler@duagon.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1814 +/- ##
========================================
- Coverage 45.2% 45.2% -0.1%
========================================
Files 173 174 +1
Lines 13721 13746 +25
========================================
+ Hits 6203 6214 +11
- Misses 7518 7532 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SSHDriver and NetworkService currently does not differentiate between no password set and password set to an empty string. Both cases resulted in that the SSH option
-o PasswordAuthentication=nois passed.There are cases where a password should be used, but it is set to an empty string.
This merge request fixes this.
Checklist