Skip to content

Conversation

@mbgg
Copy link
Contributor

@mbgg mbgg commented Dec 30, 2019

The pykush module needs an import like this:
from pykush import pykush

Fix the YKUSH driver to reflect this change.

Signed-off-by: Matthias Brugger matthias.bgg@kernel.org

Description

Checklist

  • Documentation for the feature
  • Tests for the feature
  • The arguments and description in doc/configuration.rst have been updated
  • Add a section on how to use the feature to doc/usage.rst
  • Add a section on how to use the feature to doc/development.rst
  • CHANGES.rst has been updated
  • PR has been tested
  • Man pages have been regenerated

The pykush module needs an import like this:
from pykush import pykush

Fix this YKUSH driver to reflect this change.

Signed-off-by: Matthias Brugger <matthias.bgg@kernel.org>
@codecov
Copy link

codecov bot commented Dec 30, 2019

Codecov Report

Merging #549 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #549   +/-   ##
======================================
  Coverage    56.8%   56.8%           
======================================
  Files         127     127           
  Lines        8730    8730           
======================================
  Hits         4965    4965           
  Misses       3765    3765
Impacted Files Coverage Δ
labgrid/driver/powerdriver.py 68.2% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 526cfe5...dd3a425. Read the comment docs.

@jluebbe
Copy link
Member

jluebbe commented Jan 6, 2020

It seems the readme in the project repository is wrong (it uses import pykush). The original submission of this power driver by @tgbloks depended on Yepkit/pykush#1, which is not yet merged.

@jluebbe jluebbe merged commit 04c8837 into labgrid-project:master Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants