-
Notifications
You must be signed in to change notification settings - Fork 1
[WIP] Add BiSeqDict, MultiSeqDict, and MultiBiSeqDict modules #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CharlonTank
wants to merge
8
commits into
lamdera:main
Choose a base branch
from
CharlonTank:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1498739
Add BiSeqDict, MultiSeqDict, and MultiBiSeqDict modules
CharlonTank e94d10b
Remove comparable constraints - use SeqSet instead of Set
CharlonTank 7af91f8
Add tests for BiSeqDict, MultiSeqDict, and MultiBiSeqDict
CharlonTank 3e65790
Inline list helper functions to remove elm-community/list-extra depen…
CharlonTank 3197251
Add Wire3 codec support and comprehensive README examples
CharlonTank 859635a
Expand test coverage for BiSeqDict, MultiSeqDict, and MultiBiSeqDict
CharlonTank 449d686
Rename APIs per review feedback
CharlonTank eb5ad25
Fix foldl/foldr docs: insertion order, not key order
CharlonTank File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One general thing I felt reading through as a whole was even after fully understanding what's going on, reading
BiSeqDictandMultiBiSeqDictandMultiSeqDictI kept thinking "wait hold on which one is that?", scrolling back to the titles below to see theBiSeqDict (Many-to-One)and going "Ah right yes, this is the many-to-one one.That just kept happening over and over... 😅
So what if instead, we names them the thing they are?
I'm not 100% a fan of this naming in general, but after redoing the examples with this naming at least to me reads a lot nicer and helps keep clarity in my head of what's going on, so I think it is a step better naming than the SeqDict versions:
ManyToOne (formerly
BiSeqDict)OneToMany (formerly
MultiSeqDict)ManyToMany (formerly
MultiBiSeqDict)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this naming because it naturally fits in with OneToOne.elm module I'd like to add
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this. Will wait for team consensus on exact names