Add support for PHP 8.5, Remove support for PHP 8.1

[acelaya]

Q	A
Documentation	no
Bugfix	no
BC Break	no
New Feature	no
RFC	no
QA	no

Description

This PR adds support for PHP 8.5, and drops support for PHP 8.1

[acelaya]

I'm looking into this failing test:

1) LaminasTest\Code\Reflection\ParameterReflectionTest::testGetType with data set #6 ('LaminasTest\Code\TestAsset\Cl...dClass', 'selfParameter', 'foo', 'self')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'self'
+'LaminasTest\Code\TestAsset\ClassTypeHintedClass'

[gsteel]

Looks like ReflectionType::getName() has changed - it's not documented though: https://github.com/php/php-src/blob/php-8.5.0RC3/UPGRADING

[acelaya]

Looks like ReflectionType::getName() has changed - it's not documented though: https://github.com/php/php-src/blob/php-8.5.0RC3/UPGRADING

How would you suggest proceeding here? Considering the same test would now require different assertions for PHP 8.5 and previous versions?

[alexislefebvre]

Looks like ReflectionType::getName() has changed - it's not documented though: https://github.com/php/php-src/blob/php-8.5.0RC3/UPGRADING

How would you suggest proceeding here? Considering the same test would now require different assertions for PHP 8.5 and previous versions?

There are several ways:

• use version_compare() to split the different assertions: https://www.php.net/manual/en/function.version-compare.php#example-685
• write 2 different tests and use PHPUnit’s RequiresPhp: https://docs.phpunit.de/en/12.4/attributes.html#requiresphp to target < 8.5 and >= 8.5. Older versions of PHPUnit provide it through an annotation: https://docs.phpunit.de/en/11.4/annotations.html#requires

[gsteel]

@acelaya - If you can also upgrade PHPUnit to 11.x here too, we'll lose a load of deprecations too. Normally, I'd suggest also adding failOnDeprecation and failOnPhpUnitDeprecation to phpunit.xml, but only if the changes required are minimal - we can drop all calls to ReflectionProperty::setAccessible() because it's a no-op since 8.2

[acelaya]

@acelaya - If you can also upgrade PHPUnit to 11.x here too, we'll lose a load of deprecations too. Normally, I'd suggest also adding failOnDeprecation and failOnPhpUnitDeprecation to phpunit.xml, but only if the changes required are minimal - we can drop all calls to ReflectionProperty::setAccessible() because it's a no-op since 8.2

I'm trying to do this, but it seems it might require updating psalm to v6 first.

The problem is that psalm 5 requires sebastian/diff: ^4.0 || ^5.0, while phpunit 11 requires sebastian/diff: ^6.0.

Would you be ok separating the update to PHPUnit 11 out of this PR, until the project has been updated to psalm 6? The only problem is that the deprecation warnings are making the tests be marked as failed, even though they are actually passing now.

EDIT: Actually, I could simply remove those setAccessible(...) calls. That should solve the deprecation warnings at least.

[acelaya]

Ok, CI is green now. I did the minimum changes to get it working.

As I mentioned here, I could not update to PHPUnit 11 as it has a shared dependency with psalm, but with no overlapping in version constraints. The project probably needs to update to psalm 6 first.

[gsteel]

Thanks @acelaya 👍