Conversation
|
Thanks for the pull request. Can you explain to me what these more than 1300 undocumented lines add to the functionality of the CRC calculations? |
|
Code of the project ( sources and headers) was untouched. So it doesn't affect functionality. |
|
So it doesn't add functionality to the CRC functionality, only functionality for project management. Without documentation, this PR will not be merged. |
|
cmake lists has inline comments which describes sections and purpose of each block |
|
It should basically cover the following points
|
|
As an addition: please also look at the INSTALL file in https://github.com/lammertb/libcrc/blob/master/INSTALL which details the specific reasons why the old-fashioned make tool was used in the package, rather than cmake. |
|
supports CMake
build, install, test routines available
generate cmake configuration for
find_package()generate pkg_config instructions
supports include_what_you_use, clang-tidy, unit testing, generation of examples, code coverage report