fix(simple-executor): return consistent column names using dot notation #84
+31
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update simple executor to return Cypher dot notation (e.g., p.name) instead of double underscore format (e.g., p__name) for column names. This ensures consistency with the DataFusion executor output. Changes: - Add to_cypher_column_name() function to convert to dot notation - Update apply_return_with_qualifier() to apply conversion for final output - Add unit tests for the new function - Preserve explicit user-provided aliases Fixes lance-format#30 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ChunxuTang
approved these changes
Jan 13, 2026
Collaborator
ChunxuTang
left a comment
ChunxuTang
left a comment
There was a problem hiding this comment.
Thanks for the contribution. Since the current simple executor mainly focuses on basic queries, such as property filtering and one- or two-hop queries, the implementation is sufficient for now.
Collaborator
|
@ex172000 Could you fix the style check error? |
Author
Sure, let me fix that |
beinan
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update simple executor to return Cypher dot notation (e.g.,
p.name) instead of double underscore format (e.g.,p__name) for column names. This ensures consistency with the DataFusion executor output.Changes:
to_cypher_column_name()function to convert to dot notationapply_return_with_qualifier()to apply conversion for final outputFixes #30