lando/lando#2679: Use DROP/CREATE strategy for MySQL DB reset#59
lando/lando#2679: Use DROP/CREATE strategy for MySQL DB reset#59xurizaemon wants to merge 1 commit intolando:mainfrom
Conversation
reynoldsalec
left a comment
There was a problem hiding this comment.
Change is non-working; see comment and the test results. Guessing it's something about that DB command based on the errors.
|
|
||
| # Drop and recreate database | ||
| lando_yellow "Dropping database ...\n" | ||
| $SQLSTART -e "DROP DATABASE IF EXISTS ${DATABASE}" |
There was a problem hiding this comment.
Something about this line is failing (see the test results for the PR or try using the db-export example and running the lando db-import test.sql on it).
832a539 to
30155c8
Compare
👷 Deploy request for lando-cli pending review.Visit the deploys page to approve it
|
|
30155c8 does not address the requested changes above, just rebasing to pick up current main. @reynoldsalec would you please permit the tests to run? I confess I can't actually see in "Checks" above the failed results from last time, am happy to look at the failed test if you can point me in the right direction! I do see some actions trying to run at https://github.com/xurizaemon/cli/actions/runs/3221360605/jobs/5269200430 but I don't think this is the tests we want (it's failing for lack of Docker Hub creds, and I probably don't want to push Lando images there at this point). |
|
I can now see https://github.com/lando/cli/actions/runs/3221353780/jobs/5269616590 is the failing job |
- Refs lando/lando#2679 - Replaces lando/legacy-cli#59
|
Closing PR in favour of lando/core-next#40 |

In lando/mysql#52 there's a report of Lando failing to wipe existing MySQL DB tables on db-import because it attempts to drop the table as a view first (and MySQL apparently lets you do
DROP TABLE IF EXISTSbut notDROP VIEW IF EXISTS AND IS ALSO NOT A TABLE).Existing approach came from lando/lando#2539