Skip to content

fix: handle race condition in release promote job #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AaronFeledy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle race condition in release promote job #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,20 @@ jobs:
run: |
VERSION=$(echo "$TAG_NAME" | sed 's/^v//')
PACKAGE=$(node -p "require('./package.json').name")
npm dist-tag add "$PACKAGE@$VERSION" latest
echo "::notice title=Promoted $VERSION to latest::The latest tag now points to $VERSION (was edge-only)"

# Wait for version to be available on npm (handles race with deploy job)
for i in $(seq 1 30); do
if npm view "$PACKAGE@$VERSION" version &>/dev/null; then
npm dist-tag add "$PACKAGE@$VERSION" latest
echo "::notice title=Promoted $VERSION to latest::The latest tag now points to $VERSION"
exit 0
fi
echo "Waiting for $PACKAGE@$VERSION on npm... (attempt $i/30)"
sleep 10
done

echo "::error title=Promotion failed::$PACKAGE@$VERSION not found on npm after 5 minutes"
exit 1
env:
TAG_NAME: ${{ github.event.release.tag_name }}
NODE_AUTH_TOKEN: ${{secrets.NPM_DEPLOY_TOKEN}}
Expand Down
Loading