fix(fireworks): bind_tools(strict: bool) and reasoning_content
#34343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
integration
DragosBobolea
changed the title
…nd_tools Extract strict from kwargs and pass it to convert_to_openai_tool when converting tools. This ensures that when strict is provided, it's properly used during tool conversion and removed from kwargs before calling the parent bind method. Also extract reasoning_content from API responses and store it in additional_kwargs for AIMessage objects. Add parametrized test to verify strict parameter handling. Add unit tests to verify reasoning_content extraction.
- Add noqa comment for FBT001 in parametrized test - Split long line in unit test to comply with line length limit
DragosBobolea
force-pushed
the
fix/fireworks-bind-tools-strict
branch
from
a8f171d to
3f38a0c
Compare
mdrxy
changed the title
bind_tools(strict: bool) and reasoning_content
github-actions
bot
added
fix
mdrxy
approved these changes
Dec 27, 2025
devbyteai
pushed a commit
to devbyteai/langchain
that referenced
this pull request
Jan 21, 2026
…angchain-ai#34343) Extract strict from kwargs and pass it to convert_to_openai_tool when converting tools. This ensures that when strict is provided, it's properly used during tool conversion and removed from kwargs before calling the parent bind method. Also extract reasoning_content from API responses and store it in additional_kwargs for AIMessage objects. Fixes langchain-ai#34341 and langchain-ai#34342 --------- Co-authored-by: Mason Daugherty <mason@langchain.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract strict from kwargs and pass it to convert_to_openai_tool when converting tools. This ensures that when strict is provided, it's properly used during tool conversion and removed from kwargs before calling the parent bind method.
Also extract reasoning_content from API responses and store it in additional_kwargs for AIMessage objects.
Fixes #34341 and #34342