Open
Conversation
added 2 commits
February 3, 2017 15:53
Many zone files don't include a full name and instead use a blank field in order to refer to the $ORIGIN value. Currently the library doesn't work for cases where there are multiple $ORIGIN values that also have a missing name field.
This fixes a bug in parsing zone files that have empty labelled records after secondary $ORIGIN statements. Records which have an empty label field should have their label parsed as the same as the previous record. In files with multiple $ORIGIN statements these empty labels instead pick up an increasing number of copies of their $ORIGIN value. This fixes the bug by checking whether the label of the record is the same as the previous one before determining whether to append the `unrolled_origin`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #11.
This fixes a problem in parsing empty lines for records with subsequent $ORIGIN statements.