Skip to content

Conversation

@luanfreitasdev
Copy link
Member

@luanfreitasdev luanfreitasdev commented Oct 20, 2025

This pull request refactors how IDE links are generated and used throughout the codebase, centralizing the logic into a utility function and simplifying related components. It also improves the usability and UI of the CodeSnippet component by updating keyboard navigation, file toggling, and visual styles.

IDE Link Generation Refactor

  • Moved IDE link generation logic to a new utility function generateLink in src/renderer/utils/ideHandler.ts, removing duplicate code and centralizing the implementation.
  • Updated DumpLink.vue and JobView.vue components to use the new generateLink utility, removing their local implementations and unnecessary imports.

CodeSnippet Component Usability Improvements

  • Improved keyboard navigation in CodeSnippet.vue: replaced left/right arrows with up/down for file navigation, added Escape to reset selection, and simplified toggling logic.
  • Updated file toggling to use -1 for "no file selected" instead of null, and improved active file index handling.
  • Refined UI: replaced IconArrowLight with IconChevronRight, improved visual cues for active files, and adjusted layout and scroll behavior for better readability and accessibility.

Minor UI Adjustments

  • Adjusted styles in DumpLink.vue and CodeSnippet.vue for consistent sizing, spacing, and scroll behavior.

@luanfreitasdev luanfreitasdev marked this pull request as ready for review October 20, 2025 08:42
@luanfreitasdev luanfreitasdev merged commit b536740 into 4.x Oct 20, 2025
0 of 3 checks passed
@luanfreitasdev luanfreitasdev deleted the log-viewer-improves branch October 20, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants