[FIX]: Rewrite DumpTableV2 Component, fix home view listeners being registered more than once #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that sfDump is only initiated after mouseover
Member
|
That was brilliant. Maybe we can improve and put this concept into other places later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listeners not being closed
Fix home view listeners by moving every listener function into a variable so that it can be later used to remove/close the listener (see https://www.electronjs.org/docs/latest/api/ipc-renderer#ipcrendereroffchannel-listener) for more documentation.
DumpTableV2 Performance
Improve performance by moving the
window.Sfdumpcall into a mouseover event, so that when rendering multiple components it does not hang the main thread while mounting.Fixes
#487
#488