Conversation
Drop by seqno offset first, then refine using msgno.
…2667). Fixed: send SHUTDOWN also in blocking mode. Added fallback ROGUE reject reason case it isn't set.
Co-authored-by: oviano <ovcollyer@mac.com>
Fixed minimum history condition.
Supported since GCC 7.0.
Fixes the last two remaining test failures on big-endian. These operations were all already no-ops on little-endian, and unnecessarily byteswapped the IP addresses on big-endian. Closes: #2697
authored-by: Mikolaj Malecki <mmalecki@haivision.com>
…from being established too early
* Update for compatibility with CMake 4.x * Update cxx11-macos.yaml Downgrade googletest to 1.16.x as latest one requires C++ 17 * Update cxx11-macos.yaml try to download the exact version of google test formula from homebrew history * Update cxx11-macos.yaml downgrade googletest to 1.12.1 --------- Co-authored-by: Sam Umbach <samumbach@gmail.com>
* Fixed some thread-related problems * Fixed a leak in group objects * Fixed incorrect conditional for a group closure fix * Update srtcore/group.cpp - comment typo --------- Co-authored-by: Mikolaj Malecki <mmalecki@haivision.com>
* Update iOS build scripts ~ Generate Xcode project files ~ Support build for tvOS ~ Package all variants into XCFramework bundle * Fix iOS / iOS-cxxsyncON
…tes. Enabled std shared mutex if compiling with C++17 (#3190) * [MAINT] Added optional test discovery. Added improvements for attributes * Enabled C++17 version of shared mutex when compiling in C++17 mode * Added UT discovery option to configure * Changed enabled std::shared_mutex only if compiling with stdc++-sync * Fixed problem with not updated sync.cpp SharedMutex * Fixed review findings --------- Co-authored-by: Mikolaj Malecki <mmalecki@haivision.com>
…shared mutex (#3189) * [MAINT] Added optional test discovery. Added improvements for attributes * Enabled C++17 version of shared mutex when compiling in C++17 mode * [core] Rework m_bListening to lock-free and m_GlobControlLock to use shared mutex * Added UT discovery option to configure * Changed enabled std::shared_mutex only if compiling with stdc++-sync * Fixed problem with not updated sync.cpp SharedMutex * Removed dead code * Fixed review findings * Demoted some locks on m_GlobControlLock to shared. Added false positive TSan info * Merged changes from #3200 * Added a fix that should repair the problem reported in 3196. Still needs rechecks * Fixed incorrect shared lock applied for a case when a new group is to be created (required exclusive) --------- Co-authored-by: Mikolaj Malecki <mmalecki@haivision.com>
* [build] Update Ubuntu runners to 22.04. * Update to googletest-1.12.1 * Remove Unit Tests from the ABI workflow. * Use latest version of ubuntu * Remove build-wrapper. --------- Authored-by: Clément Gérouville <cgerouville@haivision.com>
Co-authored-by: Mikolaj Malecki <mmalecki@haivision.com>
* [core] Cleanup SRT state after a fork() (issue #3177) * Free socket memory without calling the destructor. * Remove srt_cleanupAtFork() from the API. * Make it compile on systems that don't support pthread_atfork() * Remove a typo * Avoid to send shutdown packet when cleaning up after a fork. * Close the dangling UDP sockets, Free memory. * Add TODO for freeing the Send Queue after refacttoring it. * Ensure that CThread is joinable before join() * Try fix iOS-cxxsyncOFF * Replace the mutex pointer by a mutex reference. * Refactor the Multiplexer initialization. * Fix SIGSEGV * Fix Compilation error on a Debug Log * Rollback to cleaner code for the multiplexer initialization. * Add compatibility with C++11 Sync. * Apply code review changes * Replace the resetThread() macro by an inline function. Co-authored-by: Sektor van Skijlen <ethouris@gmail.com> * Reset m_CGStopCond in CUDTUnited * Rework of resetThread() * Ensure Garbage collector is in the right state after fork. * Protect ~CMultiplexer() against NULL pointers. * Protect resetAtFork() and stop() against NULL pointers. * Added fork example to the repository * Remove french comments. --------- Co-authored-by: Clément Gérouville <cgerouville@haivision.com> Co-authored-by: Sektor van Skijlen <ethouris@gmail.com> Co-authored-by: Mikolaj Malecki <mmalecki@haivision.com>
* [core] Fixed reentrancy problem of srt_strerror * [docs] Updated documentation for srt_strerror --------- Co-authored-by: Mikolaj Malecki <mmalecki@haivision.com>
* Fix SIGABRT when bonding option is too long * Move the UT to test_bonding.cpp --------- Co-authored-by: Clément Gérouville <cgerouville@haivision.com>
* [MAINT] Add fixes for CI configuration based on latest dev * Added fixes from another PR * Added lacking scripts and repos * Fixed error reported in CI. Fixed ABI entry --------- Co-authored-by: Mikolaj Malecki <mmalecki@haivision.com>
Co-authored-by: Clément Gérouville <cgerouville@haivision.com>
…orcing cookie values. (#3227) * Initial testing version of the cookie contest fix * Setting cookie contest 1.5.4 as default * [core] Restored old cookie contest. Added ignored wrong peer response on cookie collision * Fixed security report * Removed the (unnecessary now) fix for the future version compatibility * Update test/test_common.cpp - fixed a typo in a comment * Fixed TestFEC tests to be resistant of a listener-readiness bug (fixed in dev) * Try to fix the first issue * Removed remains after the screw-in cookie procedures --------- Co-authored-by: Mikolaj Malecki <mmalecki@haivision.com> Co-authored-by: Clément Gérouville <cgerouville@haivision.com>
…gorithm (#3220) * Added more logs around rexmit bandwidth * [API] raise libSRT version number to 1.5.5 * Maintenance changes * Rewrite the Bandwidth estimation system. * Merged changes from Clement's implementation * Introduce CShaper to control the retransmission BW. * Fixed with average packet size measurement * Added self-adjusting of burst period * Fixed wrong formulas and added some logs * Removed old changes for CSndRateEstimator. Blocked the use of CSndRateEstimator. * Applied most direct review fixes * Refactoring: split packLostData into smaller parts * Some cosmetic fixes * Cosmetics * Removed Tie function that was using non-C++03-compatible assignment * Stretched connection timeout for accept in FEC tests * Trying to track the problem in FEC tests on Mac * Adjusted TestFEC tests to a bug in listener missing signal --------- Co-authored-by: Mikolaj Malecki <mmalecki@haivision.com> Co-authored-by: Clément Gérouville <cgerouville@haivision.com>
…h QUIC Datagrams - research
…or SRT build (#3219) * [BUILD] Added handling of LIBSRT_ prefix when setting cmake options for SRT build * Added documentation * Apply suggestions from code review Co-authored-by: stevomatthews <smatthews@haivision.com> * Fixed text alignment after doc review --------- Co-authored-by: Mikolaj Malecki <mmalecki@haivision.com> Co-authored-by: stevomatthews <smatthews@haivision.com>
Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com>
…tion (#3259) * [BUG] Prevent blocking srt_close call from interrupting connection * Test: added check that srt_close call is not blocked. Ensured that waiting is interrupt ed on close. Ensured that the socket is closed right after wait quit * Fixed incorrect C++17 literals * Increased wait time tolerance for srt_close (failing on some slower CI machines) --------- Co-authored-by: Mikołaj Małecki <mmalecki@haivision.com>
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
#3264) * Detec IPv6 with colon to harden the check if IPv6 is used in the test. Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com> * just relies on srt::CreateAddr to resolve IP family. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com> Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
…3263) * fix bunch of typos and enable codespell via github workflow. Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com> * address review comments. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * Replace instability by unstability and insecure by unsecure. * Rollback instability! * Moving the configuration files to scripts/codespell. * Replace connenctions by connections. --------- Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com> Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Clément Gérouville <cgerouville@haivision.com>
* Fix group data length check in handshake processing * Apply suggestions from code review Changed the maximum size of copied data to the size of the array. * Apply suggestion from @ethouris Fixed through a separate variable. --------- Co-authored-by: Sektor van Skijlen <ethouris@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was automatically created using Sync Fork Chrome Extension. If there aren't any conflicts then this PR will be merged automatically else, you will need to resolve conflicts and merge manually.
If you're facing issues with this extension, please report them here.
Whizzzkid