Skip to content

Fix two issues with canonical Illumina evals#4

Open
ozan wants to merge 2 commits intolatchbio:mainfrom
ozan:illumina-gt-fixes
Open

Fix two issues with canonical Illumina evals#4
ozan wants to merge 2 commits intolatchbio:mainfrom
ozan:illumina-gt-fixes

Conversation

@ozan
Copy link

@ozan ozan commented Feb 10, 2026

Hi there, I encountered a couple of small issues with the ground truth for the Illumina canonical evals.

Firstly for the batch key choice, the correct answer I believe should be A (sample) since the sample key does in fact exist in the data. To repro:

latch cp latch://159007346.node /tmp/illumina_drg_main.h5ad
python3 -c "import anndata; print('sample' in anndata.read_h5ad('/tmp/illumina_drg_main.h5ad').obs.columns)"

... which shows as True. I confirmed that the data in sample is meaningful (3 samples, realistic distribution) so it seems like just a typo in the ground truth.

Secondly there's a minor (within tolerance) issue with the QC eval. The prompt indicates a threshold of n_genes > 1000 but the ground truth values are calculated as if the prompt is >= 1000 (greater than or equal). I've updated the prompt rather than the GT values but you could equally update these from 19,270 / 11,521 / 7,749 -> 19,259 / 11,518 / 7,741.

To repro:

"""
Data file downloaded via `latch cp latch://158807664.node /tmp/illumina_drg_qc.h5ad`
"""
import anndata, numpy as np, scipy.sparse as sp

X = anndata.read_h5ad("/tmp/illumina_drg_qc.h5ad").X
n = np.array((X > 0).sum(axis=1)).flatten() if sp.issparse(X) else (X > 0).sum(axis=1)
print(f"n_genes >  1000: {(n > 1000).sum()}  (eval instructions)")
print(f"n_genes >= 1000: {(n >= 1000).sum()}  (matches GT of 19270)")

Out:

n_genes >  1000: 19259  (eval instructions)                                                                                         
n_genes >= 1000: 19270  (matches GT of 19270)    

ozan added 2 commits February 10, 2026 16:31
Prompt indicates that `sample` key should be used when available. It is
available in the data but this is not reflected in the ground truth
choice.
The ground truth numbers are 19270, 11521 and 7749, which would be
correct for a threshold of n_genes >= 1000, not the current prompt of
n_genes > 1000 (strictly greater). Alternatively, the GT could be changed
to 19259, 11518, 7741.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant