Fix two issues with canonical Illumina evals#4
Open
ozan wants to merge 2 commits intolatchbio:mainfrom
Open
Conversation
Prompt indicates that `sample` key should be used when available. It is available in the data but this is not reflected in the ground truth choice.
The ground truth numbers are 19270, 11521 and 7749, which would be correct for a threshold of n_genes >= 1000, not the current prompt of n_genes > 1000 (strictly greater). Alternatively, the GT could be changed to 19259, 11518, 7741.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there, I encountered a couple of small issues with the ground truth for the Illumina canonical evals.
Firstly for the batch key choice, the correct answer I believe should be A (sample) since the sample key does in fact exist in the data. To repro:
latch cp latch://159007346.node /tmp/illumina_drg_main.h5ad python3 -c "import anndata; print('sample' in anndata.read_h5ad('/tmp/illumina_drg_main.h5ad').obs.columns)"... which shows as True. I confirmed that the data in
sampleis meaningful (3 samples, realistic distribution) so it seems like just a typo in the ground truth.Secondly there's a minor (within tolerance) issue with the QC eval. The prompt indicates a threshold of n_genes > 1000 but the ground truth values are calculated as if the prompt is >= 1000 (greater than or equal). I've updated the prompt rather than the GT values but you could equally update these from 19,270 / 11,521 / 7,749 -> 19,259 / 11,518 / 7,741.
To repro:
Out: