Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworking the high level api, fixes #1
Currently with the
undoableblock, you can perform any db operations. When the block closes it captures the logged events for undo stack. However this means that the operations themselves and the undo stack management happen in separate transations. There's a case that some other operation could slip between those and corrupt the undo stack.intead, introduce
databse.undoableWrite { db in ... }which wraps that all into a single transaction, plus saves an additional indent/2 lines of code.We'll keep the separate
undoableblock but name it more explicitly for cases where the new api isn't sufficient.